[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T305422

Consider deprecating/removing MW_CMDLINE_CALLBACK constant
Closed, ResolvedPublic
Actions

Description

Extracted from T253547:

@Nikerabbit wrote in T253547 task description:

MW_CMDLINE_CALLBACK seems completely unused according to code search. Consider removing it, or at least document it.

This has been unused since its introduction in r54225.

https://codesearch.wmcloud.org/search/?q=MW_CMDLINE_CALLBACK&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Maintenance: Remove unused MW_CMDLINE_CALLBACK constantmediawiki/coremaster+1 -5
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Apr 5 2022, 1:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2022, 1:31 AM
Krinkle mentioned this in T253547: Command line profiling not working on production.Apr 5 2022, 1:34 AM
Ammarpad subscribed.Apr 5 2022, 6:38 PM

This has been unused since its introduction in r54225.

It was once in use; and last appeared in r72551. It seems Maintenance::afterFinalSetup was introduced as a replacement.

gerritbot added a comment.Apr 5 2022, 6:40 PM

Change 777425 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Maintenance: Remove unused MW_CMDLINE_CALLBACK constant

https://gerrit.wikimedia.org/r/777425

gerritbot added a project: Patch-For-Review.Apr 5 2022, 6:40 PM
Krinkle assigned this task to Ammarpad.Apr 5 2022, 7:55 PM
Krinkle triaged this task as Medium priority.
Krinkle moved this task from Untriaged to 2022 | MW 1.38 / 1.39 on the Technical-Debt (Deprecation process) board.

Nice catch. Thanks for finding that.

gerritbot added a comment.Apr 5 2022, 8:12 PM

Change 777425 merged by jenkins-bot:

[mediawiki/core@master] Maintenance: Remove unused MW_CMDLINE_CALLBACK constant

https://gerrit.wikimedia.org/r/777425

Maintenance_bot removed a project: Patch-For-Review.Apr 5 2022, 8:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 5 2022, 9:00 PM
Krinkle closed this task as Resolved.Apr 6 2022, 7:37 PM
Krinkle edited projects, added Performance-Team; removed MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits