Selecting some cells on desktop:
The same selection on mobile:
Issues:
- Large empty body area
- "Merge" button becomes an edit pencil (but works)
- "Copy" action added to every context (instead of just the last one?)
Esanders | |
Mar 20 2022, 2:09 PM |
F35042980: image.png | |
Apr 7 2022, 11:51 PM |
F35042982: image.png | |
Apr 7 2022, 11:51 PM |
F35042987: image.png | |
Apr 7 2022, 11:51 PM |
F35042990: image.png | |
Apr 7 2022, 11:51 PM |
F35041562: image.png | |
Apr 6 2022, 10:23 PM |
F35041584: image.png | |
Apr 6 2022, 10:23 PM |
F35041580: image.png | |
Apr 6 2022, 10:23 PM |
F35041560: image.png | |
Apr 6 2022, 10:23 PM |
Selecting some cells on desktop:
The same selection on mobile:
Issues:
Change 772022 had a related patch set uploaded (by Esanders; author: Esanders):
[VisualEditor/VisualEditor@master] Call parent #setup method in Merge/SumCellsContextItem
Change 772022 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Call parent #setup method in Merge/SumCellsContextItem
Change 772534 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc0e3ed33)
Change 772534 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc0e3ed33)
Change 772023 had a related patch set uploaded (by Esanders; author: Esanders):
[VisualEditor/VisualEditor@master] Context: Move copy/delete buttons to MobileActionsContextItem
This next patch moves the copy/delete actions into a separate context item, solving the duplicate copy action issue, and also adding the missing "delete" action for table cell selections (which blanks the selected table cells; tables are deleted using another button in the table context button in the top left corner).
Change 772913 had a related patch set uploaded (by Esanders; author: Esanders):
[VisualEditor/VisualEditor@master] Always show label-only button for MergeCellsContextItem button
Change 772913 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Always show label-only button for MergeCellsContextItem button
Change 776211 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (05fbb163c)
Change 776211 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (05fbb163c)
Change 772023 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Context: Move copy/delete buttons to MobileActionsContextItem
Change 775352 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (41653c74a)
Change 775352 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (41653c74a)
The changes also affect how various other context items look, although the changes are minor. Screenshots below for reference:
Tablet size – Before | Tablet size – After | Phone size – Before | Phone size – After | |
---|---|---|---|---|
Image | ||||
Table cells | ||||
Alien context | ||||
Two contexts at once | ||||
Notable changes:
I'm not sure if they were all intentional, but they seemed okay to me.
Notable changes:
- In all contexts, the buttons and white space shift slightly
The changes seems sensible and probably more consistent.
- In all contexts, at tablet size, the close button is at the edge of the screen instead of aligned
This should probably be fixed
- Copy/Delete buttons now display correctly for table cells
This is correct, they expose actions that were not possible or hard to do before on mobile.
- Alien context now has a close button and looks consistent with others
This is correct, and an improvement
- Copy/Delete buttons now display at the bottom even for multiple contexts
This is correct, and an improvement
Change 778258 had a related patch set uploaded (by Esanders; author: Esanders):
[VisualEditor/VisualEditor@master] Fix position of close button on wide tablet
Change 778262 had a related patch set uploaded (by Esanders; author: Esanders):
[VisualEditor/VisualEditor@master] Match padding of mobile context header & footer
This should probably be fixed
Fixed in https://gerrit.wikimedia.org/r/778258
The changes seems sensible and probably more consistent.
Slightly increased the vertical padding of the header to match the footer in https://gerrit.wikimedia.org/r/778262
Change 778258 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix position of close button on wide tablet
Change 778262 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Match padding of mobile context header & footer
Change 778365 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0fde38782)
Change 778365 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0fde38782)
Thanks for documenting your observations with helpful screenshots.
Given this as the expected behaviour, this can can be verified since I get the same result.