Kartographer: PHP Notice: Undefined property: stdClass::$type
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	Mar 24 2022, 8:37 PM

Description

Error

mwversion: 1.39.0-wmf.4
reqId: ff359f82-e893-49e4-ab83-783def39f5f1
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined property: stdClass::$type

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.4/extensions/Kartographer/includes/SimpleStyleParser.php(213)
#0 /srv/mediawiki/php-1.39.0-wmf.4/extensions/Kartographer/includes/SimpleStyleParser.php(213): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.39.0-wmf.4/extensions/Kartographer/includes/SimpleStyleParser.php(211): Kartographer\SimpleStyleParser->normalize(stdClass)
#2 /srv/mediawiki/php-1.39.0-wmf.4/extensions/Kartographer/includes/SimpleStyleParser.php(96): Kartographer\SimpleStyleParser->normalize(array)
#3 /srv/mediawiki/php-1.39.0-wmf.4/extensions/JsonConfig/includes/JCMapDataContent.php(53): Kartographer\SimpleStyleParser->normalizeAndSanitize(array)
#4 /srv/mediawiki/php-1.39.0-wmf.4/extensions/JsonConfig/includes/JCDataApi.php(33): JsonConfig\JCMapDataContent->getSafeData(stdClass)
#5 /srv/mediawiki/php-1.39.0-wmf.4/includes/api/ApiMain.php(1897): JsonConfig\JCDataApi->execute()
#6 /srv/mediawiki/php-1.39.0-wmf.4/includes/api/ApiMain.php(871): ApiMain->executeAction()
#7 /srv/mediawiki/php-1.39.0-wmf.4/includes/api/ApiMain.php(842): ApiMain->executeActionWithErrorHandling()
#8 /srv/mediawiki/php-1.39.0-wmf.4/api.php(90): ApiMain->execute()
#9 /srv/mediawiki/php-1.39.0-wmf.4/api.php(45): wfApiMain()
#10 /srv/mediawiki/w/api.php(3): require(string)
#11 {main}

Impact

Notes

3 of these in 1.39.0-wmf.4 (T300203).

Details

Request URL: https://es.wikivoyage.org/w/api.php?format=*&formatversion=*&action=jsondata&title=*

Subject	Repo	Branch	Lines +/-
[WIP] Fix handling of null value	mediawiki/extensions/JsonConfig	master	+1 -1
Improve test coverage and stability of SimpleStyleParser	mediawiki/extensions/Kartographer	master	+96 -12
Make SimpleStyleParser a little more robust	mediawiki/extensions/Kartographer	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T300203: 🧪🚂 Trainsperiment Week: 1.39.0-wmf.1, 1.39.0-wmf.2, 1.39.0-wmf.3, 1.39.0-wmf.4 deployment blockers

Event Timeline

brennen created this task.Mar 24 2022, 8:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2022, 8:37 PM

brennen added a project: Parsoid.Mar 24 2022, 8:38 PM

This is related to some cleanup we did. We'll fix and include a test.

Reopening, this is subtly a different bug.

Change 773745 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/JsonConfig@master] [WIP] Fix handling of null value

https://gerrit.wikimedia.org/r/773745

gerritbot added a project: Patch-For-Review.Mar 25 2022, 9:31 AM

I discovered here that the JsonConfig code is lacking a validation step, there are some FIXMEs in the code about it. The reason is that when geojson is loaded through the JsonConfig mechanism, for example a ".map" in the Data namespace, then each marker can have a localized title and description. This breaks our json schema, so we skip validation until doing the final parse. There is some tech debt to clean up, we should reconsider the workflow and which code should have responsibility for handling the localized strings.

awight edited projects, added JsonConfig; removed Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-03-16.Mar 25 2022, 12:36 PM

Change 774493 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Make SimpleStyleParser a little more robust

https://gerrit.wikimedia.org/r/774493

Change 774493 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make SimpleStyleParser a little more robust

https://gerrit.wikimedia.org/r/774493

Change 774878 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Improve test coverage and stability of SimpleStyleParser

https://gerrit.wikimedia.org/r/774878

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 29 2022, 1:00 PM

Change 774878 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Improve test coverage and stability of SimpleStyleParser

https://gerrit.wikimedia.org/r/774878

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.7; 2022-04-11); removed MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Apr 5 2022, 4:00 PM

Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Apr 7 2022, 2:46 PM

Change 773745 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/JsonConfig@master] [WIP] Fix handling of null value

Reason:

https://gerrit.wikimedia.org/r/773745

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2022, 2:31 PM

The cluster is on wmf.6 now. I might have done that wrong, but I can't find this error anywhere on https://logstash.wikimedia.org, except for 5 occurrences on March 24. I think it's safe to call this done after 2 weeks of silence.

thiemowmde closed this task as Resolved.Apr 8 2022, 5:28 PM

thiemowmde claimed this task.

Kartographer: PHP Notice: Undefined property: stdClass::$typeClosed, ResolvedPublicPRODUCTION ERRORActions