[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T303796

Log when a user agrees or disagrees with the use agreement
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Background

Following on from T296415, we'd like to know how many users are agreeing to or disagreeing with (?) IP Info's terms of use.

This is split from T296472: Log when a user enables/disables IP Info.

AC
  • When I agree with IP Info's terms of use via Special:Preferences, an event should be logged
    • The event_action property should be "accept_disclaimer"
    • The event_source property should be "special_preferences"
  • When I disagree with IP Info's terms of use, an event should be logged
    • The event_action property should be "uncheck_iagree"
    • The event_source property should be "special_preferences"
Notes
  1. See the current.yaml files in the subdirectories in https://gerrit.wikimedia.org/r/plugins/gitiles/schemas/event/secondary/+/refs/heads/master/jsonschema/analytics/mediawiki for numerous examples of JSON Schema schemas that are used in production
  2. wt:Event Platform/Instrumentation How To is a step-by-step guide to creating a creating a schema and validating an event with it
  3. https://www.mediawiki.org/wiki/MediaWiki-Docker/Configuration_recipes/EventLogging is a step-by-step guide to setting up your local development environment

Details

SubjectRepoBranchLines +/-
Add EventLogging when user agrees or disagrees with use termsmediawiki/extensions/IPInfomaster+39 -11
Customize query in gerrit

Related Objects

Event Timeline

STran created this task.Mar 15 2022, 8:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2022, 8:19 AM
Aklapper added a project: IP Info.Mar 15 2022, 8:26 AM

@STran: Assuming this task is about the IP Info code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

STran added a project: Anti-Harassment.Mar 15 2022, 8:27 AM

@Aklapper That's my bad. Thanks for catching that!

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Mar 21 2022, 1:53 PM
Tchanders set the point value for this task to 5.Mar 21 2022, 4:29 PM
Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
ARamirez_WMF moved this task from Cards ready for development to AHaT Sprint 4: The Stetson on the Anti-Harassment board.Mar 22 2022, 3:51 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 4: The Stetson); removed Anti-Harassment.
Tchanders mentioned this in T296472: Log when a user enables/disables IP Info.Mar 24 2022, 4:51 PM
STran renamed this task from Log when a user enables or disables IP Info from Special:Preferences to Log when a user agrees or disagrees with the use agreemenet.Mar 25 2022, 2:34 AM
STran renamed this task from Log when a user agrees or disagrees with the use agreemenet to Log when a user agrees or disagrees with the use agreement.
STran updated the task description. (Show Details)
STran added a subscriber: Tchanders.

cc @Tchanders re: T296472#7805708 Feel free to disagree (this is just how the patch I wrote for T296472 shook out and it made sense to me to split the tickets to reflect the practical solution)

gerritbot added a comment.Mar 25 2022, 2:59 AM

Change 773672 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Add EventLogging for enable/disable IPInfo events

https://gerrit.wikimedia.org/r/773672

gerritbot added a project: Patch-For-Review.Mar 25 2022, 2:59 AM
STran added a comment.Mar 25 2022, 7:24 AM

^ that's a bad copy pasta. That patch isn't for this ticket at all. Sorry!

STran claimed this task.Mar 30 2022, 7:11 AM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 4: The Stetson) board.
Tchanders removed a project: Patch-For-Review.Mar 31 2022, 12:56 PM
gerritbot added a comment.Apr 1 2022, 8:22 AM

Change 776159 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Add EventLogging when user agrees or disagrees with use terms

https://gerrit.wikimedia.org/r/776159

gerritbot added a project: Patch-For-Review.Apr 1 2022, 8:22 AM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 4: The Stetson) board.Apr 1 2022, 8:45 AM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 5: The Bearskin); removed Anti-Harassment (AHaT Sprint 4: The Stetson).Apr 5 2022, 4:11 AM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 5: The Bearskin) board.Apr 5 2022, 4:16 AM
• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 5: The Bearskin) board.Apr 7 2022, 2:44 PM
gerritbot added a comment.Apr 7 2022, 2:46 PM

Change 776159 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add EventLogging when user agrees or disagrees with use terms

https://gerrit.wikimedia.org/r/776159

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 7 2022, 3:00 PM
• imaigwilo subscribed.Apr 7 2022, 8:17 PM

@STran I checked Beta and I do not see these events on developer tools, network tab
https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 6: The Bigouden); removed Anti-Harassment (AHaT Sprint 5: The Bearskin).Apr 19 2022, 4:16 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 19 2022, 4:17 PM
• imaigwilo moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 19 2022, 8:17 PM

this ticket is tested here: https://phabricator.wikimedia.org/T306278

• imaigwilo mentioned this in T306278: QA IP Info schema instrumentation on testwiki and production .Apr 19 2022, 8:53 PM
Niharika closed this task as Resolved.May 17 2022, 5:23 PM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits