Avoid call of static functions/access of static members from trait, it will be deprecated in php8.1
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Aug 26 2021, 8:46 PM

Description

While updating phan to a new version - T289751 - I saw the following messages:

Access of static functions on traits:

includes\OutputPage.php:4154 PhanCompatibleAccessMethodOnTraitDefinition Calling static method \ResourceLoaderOOUIModule::getSkinThemeMap on a trait is deprecated in php 8.1, it should only be called on a class using the trait (in ResourceLoaderOOUIModule::getSkinThemeMap())

includes\page\ImagePage.php:1054 PhanCompatibleAccessMethodOnTraitDefinition Calling static method \MediaFileTrait::getImageLimitsFromOption on a trait is deprecated in php 8.1, it should only be called on a class using the trait (in MediaFileTrait::getImageLimitsFromOption($user, $optionName))

Access to static members of traits:

Deprecated: Accessing static trait property ResourceLoaderOOUIModule::$builtinSkinThemeMap is deprecated, it should only be accessed on a class using the trait in /code/w/includes/resourceloader/ResourceLoaderOOUIModule.php on line 77

Details

	Subject	Repo	Branch	Lines +/-
	phan: Remove PhanCompatibleAccessMethodOnTraitDefinition suppression	mediawiki/core	REL1_38	+1 -16
	phan: Remove PhanCompatibleAccessMethodOnTraitDefinition suppression	mediawiki/core	master	+1 -18

Customize query in gerrit

Related Objects

Mentioned In: T297918: Accessing static trait property ResourceLoaderOOUIModule::$builtinSkinThemeMap is deprecated, it should only be accessed on a class using the trait
Mentioned Here: T289751: Update from Phan 3 to Phan 4 (or Phan 5)

Event Timeline

Umherirrender created this task.Aug 26 2021, 8:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2021, 8:46 PM

DannyS712 subscribed.Aug 26 2021, 8:58 PM

Zabe subscribed.Sep 25 2021, 2:06 PM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Oct 20 2021, 12:52 PM

Umherirrender unsubscribed.Nov 25 2021, 6:49 PM

Umherirrender mentioned this in T297918: Accessing static trait property ResourceLoaderOOUIModule::$builtinSkinThemeMap is deprecated, it should only be accessed on a class using the trait.Dec 16 2021, 10:14 PM

Florian renamed this task from Avoid call of static functions from trait, it will be deprecated in php8.1 to Avoid call of static functions/access of static members from trait, it will be deprecated in php8.1.Dec 17 2021, 2:59 PM

Florian merged a task: T297918: Accessing static trait property ResourceLoaderOOUIModule::$builtinSkinThemeMap is deprecated, it should only be accessed on a class using the trait.

Florian updated the task description. (Show Details)

Florian added subscribers: Florian, Umherirrender.

Reedy updated the task description. (Show Details)Dec 17 2021, 3:01 PM

Umherirrender unsubscribed.Jan 2 2022, 8:48 PM

Change 774971 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] phan: Remove PhanCompatibleAccessMethodOnTraitDefinition suppression

https://gerrit.wikimedia.org/r/774971

gerritbot added a project: Patch-For-Review.Mar 29 2022, 8:25 PM

Krinkle closed this task as Resolved.Apr 5 2022, 9:32 PM

Krinkle assigned this task to Umherirrender.

Change 774971 merged by jenkins-bot:

[mediawiki/core@master] phan: Remove PhanCompatibleAccessMethodOnTraitDefinition suppression

https://gerrit.wikimedia.org/r/774971

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 5 2022, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 5 2022, 10:30 PM

Change 787862 had a related patch set uploaded (by MarkAHershberger; author: Umherirrender):

[mediawiki/core@REL1_38] phan: Remove PhanCompatibleAccessMethodOnTraitDefinition suppression

https://gerrit.wikimedia.org/r/787862

gerritbot added a project: Patch-For-Review.May 1 2022, 12:10 AM

Change 787862 merged by jenkins-bot: