[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T270754

[1.39] Remove the deprecated Skin::getSkinStylePath()
Closed, ResolvedPublic
Actions

Description

Added unnecessary burden to core Skin code. It's more easier for every skin to just give the path directly without this indirection

  • soft deprecate
  • Hard deprecate
  • Remove in 1.39

Details

SubjectRepoBranchLines +/-
Drop Skin::getSkinStylePathmediawiki/coremaster+1 -31
Fix usages of deprecated Skin::getSkinStylePathmediawiki/skins/Metrolookmaster+7 -7
Remove $stylename indirectionmediawiki/skins/Timelessmaster+1 -1
Fix usage of deprecated Skin::getSkinStylePathmediawiki/skins/apexmaster+3 -1
Skin::getSkinStylePath() is deprecatedmediawiki/skins/Materialmaster+8 -1
Hard deprecate Skin::getSkinStylePathmediawiki/coremaster+4 -0
Deprecate Skin::getSkinStylePath()mediawiki/coremaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Ammarpad created this task.Dec 23 2020, 5:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2020, 5:40 AM
gerritbot added a comment.Dec 23 2020, 6:00 AM

Change 651312 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin::getSkinStylePath()

https://gerrit.wikimedia.org/r/651312

gerritbot added a project: Patch-For-Review.Dec 23 2020, 6:00 AM
Ammarpad added projects: Metrolook, Apex, Material.Dec 23 2020, 6:08 AM
DannyS712 added a project: Technical-Debt (Deprecation process).Dec 23 2020, 6:09 AM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Dec 23 2020, 4:00 PM

Change 651312 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin::getSkinStylePath()

https://gerrit.wikimedia.org/r/651312

Maintenance_bot removed a project: Patch-For-Review.Dec 23 2020, 4:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 23 2020, 5:00 PM
Ammarpad triaged this task as Medium priority.Dec 23 2020, 7:00 PM
Jdlrobson moved this task from Backlog to It's complicated on the MediaWiki-Core-Skin-Architecture board.Jan 5 2021, 4:42 PM
Jdlrobson moved this task from It's complicated to 1.37 release on the MediaWiki-Core-Skin-Architecture board.Jul 13 2021, 11:50 PM
Jdlrobson subscribed.Jul 14 2021, 3:47 PM

This needs a hard deprecation

I've posted a patch for Wisky
https://bitbucket.org/wikiskripta/wisky/pull-requests/1/restore-support-for-modern-mediawiki

Jdlrobson updated the task description. (Show Details)Jul 14 2021, 3:47 PM
Jdlrobson moved this task from 1.37 release to 1.38 deprecations on the MediaWiki-Core-Skin-Architecture board.Jul 30 2021, 5:42 PM
Jdlrobson raised the priority of this task from Medium to High.Sep 22 2021, 3:22 PM

Work here can now be continued.

gerritbot added a comment.Sep 22 2021, 5:28 PM

Change 722936 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Hard deprecate Skin::getSkinStylePath

https://gerrit.wikimedia.org/r/722936

gerritbot added a project: Patch-For-Review.Sep 22 2021, 5:28 PM
gerritbot added a comment.Sep 22 2021, 5:54 PM

Change 722936 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate Skin::getSkinStylePath

https://gerrit.wikimedia.org/r/722936

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 22 2021, 6:00 PM
Ammarpad claimed this task.Sep 22 2021, 6:09 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 6:10 PM
Jdlrobson renamed this task from Deprecate Skin::getSkinStylePath() to [1.39] Deprecate Skin::getSkinStylePath().Oct 6 2021, 3:49 PM
Jdlrobson renamed this task from [1.39] Deprecate Skin::getSkinStylePath() to [1.39] Remove the deprecated Skin::getSkinStylePath().
Jdlrobson lowered the priority of this task from High to Low.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from 1.38 deprecations to It's not a priority on the MediaWiki-Core-Skin-Architecture board.
Jdlrobson moved this task from It's not a priority to Deprecations and removals on the MediaWiki-Core-Skin-Architecture board.
Bongo-Cat moved this task from Backlog to Feedback on the Material board.Nov 20 2021, 12:44 AM
Bongo-Cat moved this task from Feedback to Feature Request on the Material board.
Bongo-Cat subscribed.Dec 1 2021, 8:42 PM

Is there an alternative to this hook?

Jdlrobson added a comment.Dec 1 2021, 9:27 PM

@Bongo-Cat what context are you using it in?
For most use cases you can use $this->getConfig()->get( 'StylePath' ) and complete the URL.

e.g.

// old way
$path = $this->getSkinStylePath( $name )
// new way
$path =  $this->getConfig()->get( 'StylePath' ) . "/SkinName/$name";
gerritbot added a comment.Dec 1 2021, 9:30 PM

Change 743005 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Material@master] Skin::getSkinStylePath() is deprecated

https://gerrit.wikimedia.org/r/743005

gerritbot added a project: Patch-For-Review.Dec 1 2021, 9:30 PM
gerritbot added a comment.Dec 9 2021, 4:12 PM

Change 743005 merged by jenkins-bot:

[mediawiki/skins/Material@master] Skin::getSkinStylePath() is deprecated

https://gerrit.wikimedia.org/r/743005

Jdlrobson mentioned this in rMSMAce8f8900e7ee: Skin::getSkinStylePath() is deprecated.Dec 9 2021, 4:14 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2021, 5:10 PM
Ammarpad removed Ammarpad as the assignee of this task.Feb 24 2022, 11:59 AM
Jdlrobson added a comment.Apr 4 2022, 11:37 PM

Still used by Metrolook and Apex (other skins do not work):
https://codesearch.wmcloud.org/search/?q=getSkinStylePath&i=nope&files=&excludeFiles=&repos=

gerritbot added a comment.Apr 5 2022, 10:55 AM

Change 777336 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/skins/Metrolook@master] Fix usages of deprecated Skin::getSkinStylePath

https://gerrit.wikimedia.org/r/777336

gerritbot added a project: Patch-For-Review.Apr 5 2022, 10:55 AM
gerritbot added a comment.Apr 5 2022, 11:00 AM

Change 777338 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/skins/apex@master] Fix usage of deprecated Skin::getSkinStylePath

https://gerrit.wikimedia.org/r/777338

gerritbot added a comment.Apr 5 2022, 2:00 PM

Change 777355 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Drop Skin::getSkinStylePath

https://gerrit.wikimedia.org/r/777355

gerritbot added a comment.Apr 5 2022, 2:02 PM

Change 777338 merged by jenkins-bot:

[mediawiki/skins/apex@master] Fix usage of deprecated Skin::getSkinStylePath

https://gerrit.wikimedia.org/r/777338

gerritbot added a comment.Apr 5 2022, 2:17 PM

Change 777358 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/skins/Timeless@master] Remove $stylename indirection

https://gerrit.wikimedia.org/r/777358

gerritbot added a comment.Apr 5 2022, 2:46 PM

Change 777358 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Remove $stylename indirection

https://gerrit.wikimedia.org/r/777358

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 5 2022, 3:00 PM
gerritbot added a comment.Apr 5 2022, 4:03 PM

Change 777336 merged by jenkins-bot:

[mediawiki/skins/Metrolook@master] Fix usages of deprecated Skin::getSkinStylePath

https://gerrit.wikimedia.org/r/777336

gerritbot added a comment.Apr 5 2022, 4:28 PM

Change 777355 merged by jenkins-bot:

[mediawiki/core@master] Drop Skin::getSkinStylePath

https://gerrit.wikimedia.org/r/777355

Jdlrobson closed this task as Resolved.Apr 5 2022, 4:56 PM
Jdlrobson claimed this task.

Thanks @Ammarpad !

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits