[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T256060

Jade highlighting doesn't work
Closed, ResolvedPublic
Actions

Description

Try to highlight edits with a Jade label on RecentChanges. It won't change color, but the filtering works as expected.

If you click on this link, it should load a page with options for "Productive/Goodfaith" highlighted in green. https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidecategorization=1&hidelog=1&limit=50&days=7&jade__productivegoodfaith_color=c2&urlversion=2

See https://github.com/wikimedia/mediawiki-extensions-Jade/blob/master/includes/Hooks/ChangesListSpecialPageStructuredFiltersHooks.php

And https://doc.wikimedia.org/mediawiki-core/master/php/classChangesListStringOptionsFilterGroup.html

Details

SubjectRepoBranchLines +/-
Fix row attribute conversionmediawiki/extensions/Jademaster+6 -6
Added color highlights for Jade RCFiltersmediawiki/extensions/Jademaster+66 -12
Customize query in gerrit

Event Timeline

Halfak created this task.Jun 22 2020, 8:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2020, 8:58 PM
Halfak triaged this task as High priority.Jun 22 2020, 8:58 PM
kevinbazira claimed this task.Jun 24 2020, 7:31 AM
kevinbazira edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.
gerritbot added a comment.Jun 26 2020, 8:43 AM

Change 607982 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added color highlights for Jade RCFilters

https://gerrit.wikimedia.org/r/607982

gerritbot added a project: Patch-For-Review.Jun 26 2020, 8:43 AM
gerritbot added a comment.Jun 26 2020, 4:50 PM

Change 607982 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added color highlights for Jade RCFilters

https://gerrit.wikimedia.org/r/607982

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 26 2020, 5:00 PM
gerritbot added a comment.Jul 6 2020, 7:22 AM

Change 609616 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Fix row attribute conversion

https://gerrit.wikimedia.org/r/609616

• ACraze moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Jul 6 2020, 4:32 PM
gerritbot added a comment.Jul 6 2020, 6:37 PM

Change 609616 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Fix row attribute conversion

https://gerrit.wikimedia.org/r/609616

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jul 6 2020, 7:00 PM
Halfak moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Jul 13 2020, 4:26 PM
• ACraze closed this task as Resolved.Sep 23 2020, 5:06 PM
• ACraze moved this task from Completed to Pending deployment on the Machine-Learning-Team (Active Tasks) board.
• ACraze moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits