| RHo | |
| Jun 17 2020, 9:17 PM |
| F31913971: image.png | |
| Jul 2 2020, 10:35 AM |
| F31913424: Screen Shot 2020-07-01 at 6.31.25 PM.png | |
| Jul 2 2020, 1:31 AM |
| F31869835: image.png | |
| Jun 17 2020, 9:17 PM |
The Help panel becomes wider depending on the browser window width, and covers more of the page that can potentially hinder the available space exposed for users to edit the page.
Conversely, the narrower help panel width also causes some minor display issues when there 7 pr more guidance tips - as filed on T255389.
Set the help panel to a fixed-width of 360px instead (as per the width in the original design).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make help panel 360px wide on desktop | mediawiki/extensions/GrowthExperiments | master | +1 -0 |
hi @MMiller_WMF - please prioritize as you see fit. Applying a 360px fixed width also means we don't need to consider the more drastic changes to the quick tips tabs proposed on T255389.
Change 607888 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Make help panel 360px wide on desktop
Linking with T212897, it looks like the original help panel was "small" size and then we bumped it up to medium for wider screens. I agree that keeping it as "medium" (360px width) as the default makes sense.
@RHo did you want to preserve the ability for the help panel to be wider on larger screens (500px) or should we remove that (now inactive) code?
Change 607888 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make help panel 360px wide on desktop
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /607888
Whilst there's no harm in preserving the wider panel on very large screens (say larger than 1680px), perhaps it is better for the sake of simplicity to remove this code. The marginal benefit seems OK to forgo based on the underlying reason for this task that the help panel should be as unobtrusive and block as little of the editing area as possible. However, @MMiller_WMF please chime in if you disagree.
Checked in the supported browsers - Chrome, FF, Safari, Edge and IE. No issues found.
Looks good to me too