Bad contrast of "Edit links" button in Vector skin
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Facenapalm
	Jun 4 2020, 1:54 PM

Description

Problem:
In Vector skin, the "Edit links" button of Languages section of right menu do not pass WCAG's AA level (#72777d on #f6f6f6 has contrast ratio 4.17 according to https://contrast-ratio.com/#%23f6f6f6-on-%2372777d or 4.18 according to Mozilla Firefox's dev tools; recommended value is 4.5).
We want to change it to #54595d to increase contrast.

Screenshot:

Acceptance criteria:

color of language link edit link on client is changed to #54595d

Details

	Subject	Repo	Branch	Lines +/-
	Change 'Edit link' color to make it WCAG compliant	mediawiki/extensions/Wikibase	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T96547: make it easy to prevent unwanted languages from appearing in the gray interlanguage links added by ContentTranslation

Event Timeline

Facenapalm created this task.Jun 4 2020, 1:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2020, 1:54 PM

Iniquity added a project: Accessibility.Jun 4 2020, 1:59 PM

Iniquity subscribed.

Facenapalm added a project: MediaWiki-extensions-WikibaseClient.Jun 4 2020, 2:55 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJun 4 2020, 2:55 PM

Carn subscribed.Jun 4 2020, 3:07 PM

Adding @santhosh and @Nikerabbit here, the change to originally #777 was done in part of T96547.
Agreed, if grey is the way to go, these links should feature #54595d in order to be WCAG compliant with the sidebar background.

"Edit links" is from Wikibase. What is the connection between that and CX's "grey links"?

@Nikerabbit Sorry, I put them into one bucket while inspecting, as they both currently feature the same color and should both be amended, as they fail WCAG level AA conformance.

For the record we are talking about this "edit links" link in the sidebar of a Wikipedia article:

@Sarai-WMDE @Volker_E: #54595d is the color it should be?

Lydia_Pintscher moved this task from Incoming to Needs Wikidata PM Work on the Wikidata-Campsite board.Jun 6 2020, 4:31 PM

Hey, @Lydia_Pintscher. Yes. Following Volker's input, it looks like we can proceed to amend the color of the languages "edit" links to #54595d (Base20) in order to make them WCAG compliant (AA) against the background of the side menu.

Lydia_Pintscher updated the task description. (Show Details)Jun 8 2020, 8:45 AM

Lydia_Pintscher moved this task from Needs Wikidata PM Work to Unconnected Stories on the Wikidata-Campsite board.

Jdlrobson edited projects, added Vector (legacy skin) (Tracking); removed Vector (legacy skin).Jun 8 2020, 6:20 PM

WMDE-leszek assigned this task to darthmon_wmde.Jun 18 2020, 10:10 AM

Change 607399 had a related patch set uploaded (by Iniquity; owner: Iniquity):
[mediawiki/extensions/Wikibase@master] Change 'Edit link' color to make it WCAG compliant

https://gerrit.wikimedia.org/r/607399

gerritbot added a project: Patch-For-Review.Jun 24 2020, 2:49 AM

If the entire text of the Wikibase client is on the #f6f6f6 background, then maybe it’s worth replacing all inclusions?
https://github.com/wikimedia/mediawiki-extensions-Wikibase/search?q=72777d&unscoped_q=72777d

Addshore moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jun 24 2020, 9:28 AM

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Addshore moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jun 24 2020, 10:15 AM

Change 607399 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Change 'Edit link' color to make it WCAG compliant

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /607399

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jun 30 2020, 5:00 PM

Iniquity closed this task as Resolved.Jun 30 2020, 8:47 PM

Iniquity claimed this task.