[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Edit conflict resulted in mangled section heading (whole edit summary used instead of section heading)
Closed, ResolvedPublic

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex subscribed.

Okay, so I found the code causing this – when switching from NWE in section=new mode to the old wikitext editor (e.g. when we need to resolve an edit conflict), we incorrectly send the generated edit summary in the parameter that should contain only the heading text. I can fix that.

The real enigma here for me is, how did you manage to get an edit conflict while posting a new section? I thought that is not possible.

Also, I found this old task where the same issue happens, but apparently there was no edit conflict or editor switching involved: T163370. The plot thickens.

Change 583146 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix new section title when switching from NWE to OWE

https://gerrit.wikimedia.org/r/583146

Change 583146 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix new section title when switching from NWE to OWE

https://gerrit.wikimedia.org/r/583146

matmarex moved this task from Upcoming to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

There are no "normal" reproduction steps for this (unless @Whatamidoing-WMF knows how it happened?), but I've been testing it by running ve.init.target.onSaveDialogResolveConflict() in the browser console after opening the save dialog (which will open the edit conflict screen, or immediately save your changes if there is no actual conflict).