[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T248484

Core's selenium tests should not depend on Vector
Closed, ResolvedPublic
Actions

Description

While looking at T248281 I realized that core's selenium tests depend on Vector, but they don't need to. Switching some selectors and looking at export JS config vars instead of Vector's #pt-username selector should be enough.

Details

SubjectRepoBranchLines +/-
Remove Vector from default setupintegration/quibblemaster+9 -24
[selenium] Make tests skin agnosticmediawiki/coremaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Mar 25 2020, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2020, 3:21 PM
gerritbot added a comment.Mar 25 2020, 3:22 PM

Change 583361 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] [selenium] Make tests skin agnostic

https://gerrit.wikimedia.org/r/583361

gerritbot added a project: Patch-For-Review.Mar 25 2020, 3:22 PM
kostajh added a project: Quality-and-Test-Engineering-Team.Mar 25 2020, 3:24 PM
kostajh added a subscriber: zeljkofilipin.
zeljkofilipin triaged this task as Medium priority.Mar 25 2020, 4:09 PM
zeljkofilipin added a project: User-zeljkofilipin.
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
gerritbot added a comment.Mar 27 2020, 7:49 PM

Change 583361 merged by jenkins-bot:
[mediawiki/core@master] [selenium] Make tests skin agnostic

https://gerrit.wikimedia.org/r/583361

kostajh closed this task as Resolved.Mar 27 2020, 7:50 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 27 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 27 2020, 8:10 PM
gerritbot added a comment.Apr 20 2020, 12:08 PM

Change 591033 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/quibble@master] Remove Vector from default setup

https://gerrit.wikimedia.org/r/591033

gerritbot added a project: Patch-For-Review.Apr 20 2020, 12:08 PM
gerritbot added a comment.May 4 2020, 7:38 PM

Change 591033 abandoned by Kosta Harlan:
Remove Vector from default setup

Reason:
per latest comment

https://gerrit.wikimedia.org/r/591033

Maintenance_bot removed a project: Patch-For-Review.May 4 2020, 8:10 PM
• Demian mentioned this in T247606: Selenium test 'should be able to log in @daily' fails when the user menu is hidden.May 27 2020, 2:38 AM
• Demian subscribed.May 27 2020, 2:42 AM
kostajh mentioned this in T276900: Selenium tests fail if Vector skin is not installed.Mar 9 2021, 11:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits