[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Regression: MediaWiki:Minerva.css is being loaded on mobile site
Closed, ResolvedPublic

Description

Previously MediaWiki:Minerva.css was not loaded on mobile and was reserved for desktop Minerva (note in English Wikipedia for example there are rules for styling navboxes which are never present in mobile HTML).

In T237050 we accidentally added this module to the mobile site. This was unintentional and led to lots of confusion on wiki relating to hyphen styling.

Expected behaviour is MediaWiki:Minerva.css only loads for desktop Minerva users.

Event Timeline

Change 583143 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Do not load MediaWiki:Minerva.css on mobile

https://gerrit.wikimedia.org/r/583143

Change 583143 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Do not load MediaWiki:Minerva.css on mobile

https://gerrit.wikimedia.org/r/583143

Jdlrobson claimed this task.

Can confirm fix. Now this stylesheet only loads on desktop. I've also fixed the hyphen issue on wiki. https://en.wikipedia.org/w/index.php?title=MediaWiki%3AMinerva.css&type=revision&diff=947375295&oldid=880043152