WikibaseLexeme CI broken due to Title constructor being private
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Mar 16 2020, 6:49 PM

Description

The Title constructor was recently made private (CC @Daimona), which seems to have broken WikibaseLexeme’s CI.

Specifically, the following code:

/**                                                                                                                                                                      
 * @return Title|MockObject                                                                                                                                              
 */
private function getMockTitle() {
	return $this->getMockBuilder( Title::class )->getMock();
}

now throws an exception. Is there a suggested replacement?

Details

	Subject	Repo	Branch	Lines +/-
	Fix LexemeContentTest for Title constructor being private	mediawiki/extensions/WikibaseLexeme	master	+1 -1

Customize query in gerrit

Related Objects

Duplicates Merged Here: T247806: Make WikibaseLexeme compatible with PHP 7.4

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 16 2020, 6:49 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 16 2020, 6:49 PM

Restricted Application added a subscriber: kerberizer. · View Herald Transcript

Sorry, I messed up the title (and in such a way that it caused Herald to add an extra subscriber).

In T247782#5973542, @Lucas_Werkmeister_WMDE wrote:

Sorry, I messed up the title (and in such a way that it caused Herald to add an extra subscriber).

Haha, no worries at all! ;)

Change 580111 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix LexemeContentTest for Title constructor being private

https://gerrit.wikimedia.org/r/580111

gerritbot added a project: Patch-For-Review.Mar 16 2020, 6:54 PM

Meh, I thought these test-only errors would have been spotted by the wmf-gate jobs. Sorry for the breakage :(

WMDE-leszek subscribed.Mar 17 2020, 7:50 AM

Daimona merged a task: T247806: Make WikibaseLexeme compatible with PHP 7.4.Mar 17 2020, 9:05 AM

Daimona added subscribers: Jdforrester-WMF, Reedy, Aklapper.

Michael subscribed.Mar 17 2020, 10:38 AM

Change 580111 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix LexemeContentTest for Title constructor being private

https://gerrit.wikimedia.org/r/580111

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 17 2020, 11:44 AM

Lucas_Werkmeister_WMDE claimed this task.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 17 2020, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2020, 12:10 PM

WikibaseLexeme CI broken due to Title constructor being privateClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

WikibaseLexeme CI broken due to Title constructor being private
Closed, ResolvedPublic
Actions