Fix misleading help text talking about yellow/blue knobs
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	thiemowmde
	Mar 14 2020, 2:01 PM

Description

Multiple scripts intentionally change the yellow/blue color scheme RevisionSlider is using:

VisualEditor

Screenshot from 2020-03-14 14-50-46.png (630×1 px, 58 KB)

These overrides are in the VisualEditor extension: https://phabricator.wikimedia.org/diffusion/EVED/browse/master/modules/ve-mw/preinit/styles/ve.init.mw.DiffPage.less$32
Impact: At the moment, this is available to all users that have the "Visual differences" Beta feature enabled. The moment this is not in Beta any more, it will be available to all users.

Schnark

Screenshot from 2020-03-14 14-47-29.png (476×1 px, 65 KB)

The code that overrides our colors: https://de.wikipedia.org/wiki/Benutzer:Schnark/js/diff.js
Impact: This is only available to users that have the user script set up. Installation instructions are here: https://de.wikipedia.org/wiki/Benutzer:Schnark/js/diff

What's the issue?

As far as I can see only one: some help text talks about yellow and blue knobs. Users actually reported this: https://www.mediawiki.org/wiki/Topic:Vifffq6tmq582jkw

Details

	Subject	Repo	Branch	Lines +/-
	Update help text talking about specific colors	mediawiki/extensions/RevisionSlider	master	+1 -1

Customize query in gerrit

Event Timeline

thiemowmde created this task.Mar 14 2020, 2:01 PM

Restricted Application added projects: TCB-Team (now WMDE-TechWish), Design. · View Herald TranscriptMar 14 2020, 2:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 579730 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/RevisionSlider@master] Update help text talking about specific colors

https://gerrit.wikimedia.org/r/579730

gerritbot added a project: Patch-For-Review.Mar 14 2020, 2:03 PM

thiemowmde moved this task from Incoming to Doing on the Revision-Slider board.Mar 14 2020, 2:03 PM

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-03-04 board.

thiemowmde moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-03-04 board.Mar 16 2020, 9:41 AM

Change 579730 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Update help text talking about specific colors

https://gerrit.wikimedia.org/r/579730

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 16 2020, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2020, 10:10 AM

WMDE-Fisch set the point value for this task to 1.Mar 17 2020, 11:24 AM

thiemowmde closed this task as Resolved.Mar 17 2020, 12:38 PM

thiemowmde moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-03-04 board.

	F31681030: Screenshot from 2020-03-14 14-47-29.png
	Mar 14 2020, 2:01 PM

	F31681033: Screenshot from 2020-03-14 14-50-46.png
	Mar 14 2020, 2:01 PM