[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T246597

Use 'infoFilled' icon for “More about this tool” link in CX sidebar
Closed, ResolvedPublic
Actions

Description

Currently, “More about this tool” link uses 'info' icon which doesn't align to icon guidelines and has just been continued to be used due to certain in-context usage advantages when interface would otherwise become to heavy when used as hover info multiple times on a page like in forms or in OOUI demo.

In CX sidebar, 'infoFilled' seems to be more appropriate:

Current statusProposed
image.png (558×922 px, 40 KB)
image.png (488×886 px, 37 KB)

Details

SubjectRepoBranchLines +/-
Replace 'info' with 'infoFilled' icon in sidebarmediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Mar 2 2020, 1:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2020, 1:02 AM
Volker_E added a comment.Mar 2 2020, 1:03 AM

@Pginer-WMF Pls provide feedback if you see this similar?

gerritbot added a comment.Mar 2 2020, 1:06 AM

Change 575805 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/ContentTranslation@master] Replace 'info' with 'infoFilled' icon in sidebar

https://gerrit.wikimedia.org/r/575805

gerritbot added a project: Patch-For-Review.Mar 2 2020, 1:06 AM
Pginer-WMF added a subscriber: santhosh.Mar 2 2020, 8:35 AM
In T246597#5931116, @Volker_E wrote:

@Pginer-WMF Pls provide feedback if you see this similar?

Yes. The proposed version of the icon makes more sense.

We are in the process of refactoring the dashboard (T243583). So I'll leave to @santhosh whether it is better to apply the change now or keep track for the new version.

gerritbot added a comment.Mar 31 2020, 2:06 PM

Change 575805 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Replace 'info' with 'infoFilled' icon in sidebar

https://gerrit.wikimedia.org/r/575805

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2020, 2:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 31 2020, 3:00 PM
Volker_E closed this task as Resolved.Apr 7 2020, 7:06 AM

Closing this successfully.

Volker_E claimed this task.Apr 7 2020, 7:06 AM
Volker_E added a subscriber: Pginer-WMF.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits