The number passed to the dialog is not localized
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Huji
	Feb 11 2020, 12:15 AM

Description

When you find and replace text using the WikiEditor dialogue the number of matches is not localized. For instance, in Persian you will see a message like 7 جایگزینی انجام شد instead of ۷ جایگزینی انجام شد

The reason is that this line of code passes the number of matches (i.e. match.length) without first localizing it:

.text( mw.msg( 'wikieditor-toolbar-tool-replace-success', match.length ) )

Details

	Subject	Repo	Branch	Lines +/-
	Localize numbers before passing to mw.msg	mediawiki/extensions/WikiEditor	master	+3 -4

Customize query in gerrit

Event Timeline

Huji created this task.Feb 11 2020, 12:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2020, 12:15 AM

Aklapper added a project: I18n.Feb 11 2020, 2:25 AM

Change 583520 had a related patch set uploaded (by Happy5214; owner: Happy5214):
[mediawiki/extensions/WikiEditor@master] Localize numbers before passing to mw.msg

https://gerrit.wikimedia.org/r/583520

gerritbot added a project: Patch-For-Review.Mar 26 2020, 6:57 AM

happy5214 claimed this task.Mar 26 2020, 6:58 AM

happy5214 moved this task from Backlog to Doing on the WikiEditor (2010) board.Mar 26 2020, 7:00 AM

Thank you in advance @happy5214

Change 583520 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Localize numbers before passing to mw.msg

https://gerrit.wikimedia.org/r/583520

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 30 2020, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2020, 9:10 AM

TheDJ closed this task as Resolved.Mar 30 2020, 9:37 AM

happy5214 moved this task from Doing to Closed on the WikiEditor (2010) board.Feb 4 2021, 12:17 PM