[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T235154

show error when editor can't edit the statement because of permission errors on the repository
Closed, ResolvedPublic13 Estimated Story Points
Actions

Assigned To
• Tonina_Zhelyazkova_WMDE
Authored By
Lydia_Pintscher
Oct 10 2019, 8:11 AM
Tags
Referenced Files
F31538669: image.png
Jan 29 2020, 1:23 PM
F31535589: Bildschirmfoto von 2020-01-27 17-28-00.png
Jan 27 2020, 4:35 PM
F31506072: cascadeProtectionClient.png
Jan 9 2020, 12:51 PM
F31506074: cascadeProtectionRepo.png
Jan 9 2020, 12:51 PM
F31464867: image.png
Dec 10 2019, 10:31 AM
F31464876: PermissionsRepo_Mobile.png
Dec 10 2019, 10:31 AM
F31464869: 2. selected 1st message.png
Dec 10 2019, 10:31 AM
F31464873: AllErrors_DisplayOne.png
Dec 10 2019, 10:31 AM
View All 31 Files
Subscribers
Addshore
Aklapper
Charlie_WMDE
Lucas_Werkmeister_WMDE
Lydia_Pintscher
Michael
• Pablo-WMDE
View All 10 Subscribers

Description

As an editor on the client I want to be warned if I can't make an edit on the repository in order to not waste my time.

Problem:
The Item where the statement is coming from might be protected on the repository or the editor might be blocked. In this case we want to tell them that they can't edit the statement they are trying to edit.

We have 3 cases that can happen:

  • The item is fully protected
  • The item is semi-protected
  • The user is blocked on Wikidata

Screenshots/mockups:
more details in figma mock

Desktop - Fully protected

ItemFullyProtected (Desktop).png (488×500 px, 34 KB)

Desktop - Semi-protected

image.png (880×791 px, 90 KB)

Desktop - Blocked on repository

2. selected 1st message.png (488×500 px, 30 KB)

Mobile version (please note that typography switches to 16px size/24px line-height on mobile)

PermissionsRepo_Mobile.png (706×375 px, 40 KB)

(Blocked on client +) blocked on repo+ protected on repo

AllErrors.png (488×500 px, 23 KB)

AllErrors_DisplayOne.png (655×500 px, 42 KB)

Desktop - Cascade protection client

cascadeProtectionClient.png (562×500 px, 30 KB)

Desktop - Cascade protection repo

cascadeProtectionRepo.png (563×500 px, 29 KB)

Links in mocks

  • fully protected: $repourl/wiki/Project:Page_protection_policy
  • administrator(s): $repourl/wiki/Project:Administrators
  • protected: $repourl/wiki/Project:Page_protection_policy
  • protection log: $repourl/wiki/Special:Log/protect?page=Q$
  • editing disputes: $repourl/wiki/Project:Edit_warring
  • discuss this item: link to discussion page of respective item
  • semi-protected: $repourl/wiki/Project:Page_protection_policy
  • autoconfirmed/confirmed users: $repourl/wiki/Project:Autoconfirmed_users
  • log in: link to the client's log in page
  • create an account on $repoName: link to the client's account creation page (side-note from charlie: not sure about this one since editors might think that this is where they'll need to make the edits to get autoconfirmed but then still won't be able to edit since the auto confirmation happened on the wrong wiki)

BDD
GIVEN a protected Item
WHEN a user without the necessary edit rights tries to edit it in the bridge
THEN an error message is shown when opening the bridge
AND the edit can't be performed

GIVEN an editor that is blocked on the repository
WHEN they try to edit in the bridge
THEN an error message is shown when opening the bridge
AND the edit can't be performed

Acceptance criteria:

  • loading bar is replaced by error message as soon as possible (but abiding by the constraints listed in this ticket T232468) due to any of the reasons listed
  • the editability status depends on the Item the statement is coming from (which is not necessarily the one connected to the article via the sitelink)
  • These screens do not have a save button
  • The green-blueish side margin outlined on the specs must always be respected: margin sizes will not change due to text size changes
  • In case of triple error, notifications should be displayed following the order established by the designs: blockage on client + blockage on repo + item protection
  • Error notifications are accompanied by an expandable link component (find specs in WiKit): the link displays the error details on click/press
  • In case only a single message is displayed, then the expandable link is activated by default (error details are displayed) (See example "Desktop - Fully protected")
  • In case of a negative permission result (i.e. when showing the error(s)), the opening of bridge should not be tracked (as implemented in T231204).

Details

SubjectRepoBranchLines +/-
ErrorPermission: fix content spacingmediawiki/extensions/Wikibasemaster+12 -10
bridge: refactor ErrorPermissionInfomediawiki/extensions/Wikibasemaster+107 -145
bridge: remove resolved TODO from testmediawiki/extensions/Wikibasemaster+0 -2
Remove IP address from i18n messagesmediawiki/extensions/Wikibasemaster+4 -4
bridge: move data type tracking into BRIDGE_INITmediawiki/extensions/Wikibasemaster+81 -42
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT228066 Step 1: Error States of Data-Bridge [Tracking] (impact: medium)
 Resolved• Tonina_Zhelyazkova_WMDET235154 show error when editor can't edit the statement because of permission errors on the repository
 ResolvedLucas_Werkmeister_WMDET237522 Investigate options to get block and protection info from remote repository
 ResolvedMichaelT237523 Create Interface for Service about user being allowed to edit entity
 ResolvedMichaelT237524 Create Error vector in store root layer and enum of possible error reasons
 Resolved• Matthias_Geisler_WMDET237525 modify Message plugin in order to be able to use parameters
 ResolvedLucas_Werkmeister_WMDET237526 create messages according to mocks
 Resolved• Matthias_Geisler_WMDET237527 Add notice component
 Resolved• Tonina_Zhelyazkova_WMDET237528 Create permission error component
 Resolved• Pablo-WMDET237536 Wire up Permission Error Component in Error Component
 ResolvedLucas_Werkmeister_WMDET238918 Add full item title to bridge RegExp and pass to app
 Declined• Matthias_Geisler_WMDET239128 Parse/Render messages in mediawiki
Declined• Matthias_Geisler_WMDET239129 Modify mw.messages
 ResolvedLucas_Werkmeister_WMDET239336 Implement service to get permission errors for editing a page
 OpenNoneT240565 Expose own IP address in API
 ResolvedLucas_Werkmeister_WMDET239710 Implement service to combine permission errors from repo and client
 ResolvedLucas_Werkmeister_WMDET241823 Dispatch combined permission service when application is started
 Resolved• Pablo-WMDET242413 Add ability to create article links to repo
 ResolvedLucas_Werkmeister_WMDET242832 Format user names in error messages
 ResolvedMichaelT243010 Hide save button if application is in error state
 Resolved• Pablo-WMDET243230 Browser test permission violations
 ResolvedLucas_Werkmeister_WMDET243917 Missing line-height on ErrorPermission heading
 ResolvedLucas_Werkmeister_WMDET243918 $2 argument not provided in cascade-protected message on repo and client
 ResolvedLucas_Werkmeister_WMDET243919 mediawiki.jqueryMsg module not loaded

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Lucas_Werkmeister_WMDE closed subtask T237525: modify Message plugin in order to be able to use parameters as Resolved.Dec 2 2019, 11:44 AM
Charlie_WMDE closed subtask T237527: Add notice component as Resolved.Dec 2 2019, 12:42 PM
Lucas_Werkmeister_WMDE mentioned this in T239451: DBPerformance: Unexpected masterConns on GET from ApiQueryInfo via BlockManager.php.Dec 2 2019, 4:09 PM
Charlie_WMDE updated the task description. (Show Details)Dec 3 2019, 1:53 PM
• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-11.Dec 4 2019, 9:57 AM
Lucas_Werkmeister_WMDE added a comment.EditedDec 5 2019, 5:01 PM

Questions about the messages:

  • Are $repoName and $clientName really links? If yes, to what URL?
  • What’s the URL for “templates and items”?
  • Why does “protection log” link to Special:ProtectedPages rather than Special:Log/protect?

Edit: “protection log” could also link to that particular item’s protection log, using Special:Log/protect?page=Q123

• Pablo-WMDE added a comment.EditedDec 6 2019, 1:22 PM

Another question that came up: "this value is currently semi-protected on $repoName and can be edited only be autoconfirmed/confirmed users", second from last mock-up.
This sounds like it iterates the groups that can. In practice we know about rights which need to be granted. Certainly we can try to deduce the groups from these but we'd put more effort into this than MediaWiki itself (uses fixed messages per "reason", e.g. "semi-protected"). Is that intended?

(Praise @Lucas_Werkmeister_WMDE for keeping our terminology consistent!)

Lucas_Werkmeister_WMDE closed subtask T237523: Create Interface for Service about user being allowed to edit entity as Resolved.Dec 6 2019, 2:53 PM
Charlie_WMDE added a comment.Dec 10 2019, 10:17 AM
In T235154#5715954, @Lucas_Werkmeister_WMDE wrote:

Questions about the messages:

  • Are $repoName and $clientName really links? If yes, to what URL?

i was thinking we'd link them to the main pages of the projects but thinking about this more i don't see the point of having these be links. I'm gonna remove them.

  • What’s the URL for “templates and items”?

removed

  • Why does “protection log” link to Special:ProtectedPages rather than Special:Log/protect?

Edit: “protection log” could also link to that particular item’s protection log, using Special:Log/protect?page=Q123

good idea, let's do that!

Charlie_WMDE updated the task description. (Show Details)Dec 10 2019, 10:18 AM
Charlie_WMDE updated the task description. (Show Details)Dec 10 2019, 10:31 AM
Lucas_Werkmeister_WMDE added a comment.Dec 11 2019, 12:37 PM

Another thing I just realized…

If there are no relevant entries, the Item may have been moved after being protected.

Items can’t be moved :)

Lucas_Werkmeister_WMDE added a comment.Dec 11 2019, 12:43 PM

If there are no relevant entries, the Item may have been moved after being protected.

Items can’t be moved :)

I removed the sentence from I3dcd49dd4c, but @Michael pointed out that the item may have been merged. I think that’s indeed possible, so I guess I should add the sentence back, but saying “the Item may have been merged into a protected Item”?

(Actually, I’m not sure if we would get an error in that case… I think we don’t really handle redirects yet, in general?)

Charlie_WMDE added a comment.Dec 11 2019, 2:12 PM
In T235154#5731833, @Lucas_Werkmeister_WMDE wrote:

If there are no relevant entries, the Item may have been moved after being protected.

Items can’t be moved :)

I removed the sentence from I3dcd49dd4c, but @Michael pointed out that the item may have been merged. I think that’s indeed possible, so I guess I should add the sentence back, but saying “the Item may have been merged into a protected Item”?

(Actually, I’m not sure if we would get an error in that case… I think we don’t really handle redirects yet, in general?)

Is this something you have to find out first? Otherwise if there's no error state, it would be great if you coudl file a ticket for that in general and for now leave the sentence out of the bridge.

• Tonina_Zhelyazkova_WMDE added subscribers: • SaraiSan, • Tonina_Zhelyazkova_WMDE.Dec 11 2019, 2:40 PM

There are differences between the mocks in this ticket and the corresponding ones in Figma.
What I noticed so far:

  • the expand area now says "See details" and the icon is different
  • The sentence "This value, is currently fully protected on $repoName and can be edited only by administrators." used to be bold and now it is not.

Depending on which ones are correct I will or will not make changes to my current task and -1 or +1 Lucas's patch. So I think we should make a decision ASAP as this is in the current sprint.

@Charlie_WMDE @SaraiSan

Lucas_Werkmeister_WMDE added a comment.EditedDec 11 2019, 3:20 PM

(Actually, I’m not sure if we would get an error in that case… I think we don’t really handle redirects yet, in general?)

Is this something you have to find out first? Otherwise if there's no error state, it would be great if you coudl file a ticket for that in general and for now leave the sentence out of the bridge.

I tried it out, and if the target item is a redirect, we’ll get an error when opening the bridge (“Result does not contain relevant entity.”). So I guess we can leave the sentence out for now, and I’ll file a task for handling redirects(?) – edit: T240463

• Sarai-WMDE updated the task description. (Show Details)Dec 11 2019, 3:20 PM
Lucas_Werkmeister_WMDE closed subtask T237524: Create Error vector in store root layer and enum of possible error reasons as Resolved.Dec 11 2019, 5:14 PM
Charlie_WMDE added a comment.Dec 12 2019, 12:27 PM
In T235154#5732304, @Lucas_Werkmeister_WMDE wrote:

(Actually, I’m not sure if we would get an error in that case… I think we don’t really handle redirects yet, in general?)

Is this something you have to find out first? Otherwise if there's no error state, it would be great if you coudl file a ticket for that in general and for now leave the sentence out of the bridge.

I tried it out, and if the target item is a redirect, we’ll get an error when opening the bridge (“Result does not contain relevant entity.”). So I guess we can leave the sentence out for now, and I’ll file a task for handling redirects(?) – edit: T240463

yes, thank you!

Charlie_WMDE added a comment.Dec 12 2019, 12:28 PM
In T235154#5732137, @Tonina_Zhelyazkova_WMDE wrote:

There are differences between the mocks in this ticket and the corresponding ones in Figma.
What I noticed so far:

  • the expand area now says "See details" and the icon is different
  • The sentence "This value, is currently fully protected on $repoName and can be edited only by administrators." used to be bold and now it is not.

Depending on which ones are correct I will or will not make changes to my current task and -1 or +1 Lucas's patch. So I think we should make a decision ASAP as this is in the current sprint.

@Charlie_WMDE @SaraiSan

@Tonina_Zhelyazkova_WMDE are you unblocked on this?

• Tonina_Zhelyazkova_WMDE added a comment.Dec 12 2019, 12:35 PM
In T235154#5735639, @Charlie_WMDE wrote:
In T235154#5732137, @Tonina_Zhelyazkova_WMDE wrote:

There are differences between the mocks in this ticket and the corresponding ones in Figma.
What I noticed so far:

  • the expand area now says "See details" and the icon is different
  • The sentence "This value, is currently fully protected on $repoName and can be edited only by administrators." used to be bold and now it is not.

Depending on which ones are correct I will or will not make changes to my current task and -1 or +1 Lucas's patch. So I think we should make a decision ASAP as this is in the current sprint.

@Charlie_WMDE @SaraiSan

@Tonina_Zhelyazkova_WMDE are you unblocked on this?

Yes, we're taking Figma as the source of truth, as we agreed yesterday.

Charlie_WMDE added a comment.Dec 12 2019, 12:36 PM
In T235154#5735654, @Tonina_Zhelyazkova_WMDE wrote:
In T235154#5735639, @Charlie_WMDE wrote:
In T235154#5732137, @Tonina_Zhelyazkova_WMDE wrote:

There are differences between the mocks in this ticket and the corresponding ones in Figma.
What I noticed so far:

  • the expand area now says "See details" and the icon is different
  • The sentence "This value, is currently fully protected on $repoName and can be edited only by administrators." used to be bold and now it is not.

Depending on which ones are correct I will or will not make changes to my current task and -1 or +1 Lucas's patch. So I think we should make a decision ASAP as this is in the current sprint.

@Charlie_WMDE @SaraiSan

@Tonina_Zhelyazkova_WMDE are you unblocked on this?

Yes, we're taking Figma as the source of truth, as we agreed yesterday.

oki doke. just wanted to make sure :)

Lucas_Werkmeister_WMDE closed subtask T239710: Implement service to combine permission errors from repo and client as Resolved.Dec 12 2019, 12:59 PM
Lucas_Werkmeister_WMDE added a comment.EditedDec 13 2019, 4:12 PM
In T235154#5717975, @Pablo-WMDE wrote:

Another question that came up: "this value is currently semi-protected on $repoName and can be edited only be autoconfirmed/confirmed users", second from last mock-up.
This sounds like it iterates the groups that can. In practice we know about rights which need to be granted. Certainly we can try to deduce the groups from these but we'd put more effort into this than MediaWiki itself (uses fixed messages per "reason", e.g. "semi-protected"). Is that intended?

To tie this one up – if I recall correctly, we agreed with Lydia that it’s fine to just say “autoconfirmed” (hard-coded into the message, without “/confirmed”), since MediaWiki does this as well (semiprotectedpagewarning). Wiki admins who want the text to be fully accurate can override it on their wiki to mention additional groups.

We also seem to be missing mocks for cascade-protected pages. This can come from two ends: the repo, and the client. (Sadly, the edit links aren’t hidden on cascade-protected client pages.)

On the repository wiki, cascade protection of the item might be theoretically possible (I haven’t tried it out), but on Wikidata in particular, the list of cascade-protected pages lists only one single page, which hasn’t been edited since 2013 and doesn’t transclude anything else. I think it’s safe to say that we don’t use cascade protection on Wikidata.

On client wikis, cascade protection doesn’t seem to be all that popular either. English Wikipedia has 124 cascade-protected pages that aren’t directly protected, none of them in the main namespace (Quarry); German Wikipedia has 1949 such pages, all of them in the project namespace (Quarry); Commons has 404 such pages, in the Project and File namespaces; on French, Russian and Basque Wikipedia, I found no such pages at all. If you also search pages that are otherwise protected, you find a grand total of six pages in the main namespace on English Wikipedia, and not much more on the other wikis I checked.

I’m not sure where I’m going with this, to be honest… we should still handle these errors somehow (and I guess the cascade-protected files on Commons are the most realistic case where users would encounter them), but not lose too much sleep over it?

Lucas_Werkmeister_WMDE added a comment.Dec 13 2019, 4:39 PM
  • log in: link to the client's log in page
  • create an account on $repoName: link to the client's account creation page (side-note from charlie: not sure about this one since editors might think that this is where they'll need to make the edits to get autoconfirmed but then still won't be able to edit since the auto confirmation happened on the wrong wiki)

Should these really point to the client even though the surrounding text talks about the repo?

Lucas_Werkmeister_WMDE closed subtask T239336: Implement service to get permission errors for editing a page as Resolved.Dec 13 2019, 5:12 PM
Lucas_Werkmeister_WMDE changed the status of subtask T237526: create messages according to mocks from Open to Stalled.Dec 16 2019, 3:43 PM
gerritbot added a comment.Dec 16 2019, 6:11 PM

Change 558150 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: dispatch permission check on BRIDGE_INIT

https://gerrit.wikimedia.org/r/558150

gerritbot added a project: Patch-For-Review.Dec 16 2019, 6:11 PM
• Pablo-WMDE added a comment.EditedDec 18 2019, 9:42 AM

How will permission violations affect the opening tracking as implemented during T231204: track Bridge openings by property datatype? /cc @Lydia_Pintscher

Talking with Lydia: "don't count it" (i.e. do not perform the opening tracking in case of opening error).

• Tonina_Zhelyazkova_WMDE added a parent task: T228066: Step 1: Error States of Data-Bridge [Tracking] (impact: medium).Dec 19 2019, 10:43 AM
gerritbot added a comment.Dec 19 2019, 3:37 PM

Change 559515 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: move data type tracking into BRIDGE_INIT

https://gerrit.wikimedia.org/r/559515

gerritbot added a comment.Dec 20 2019, 3:31 PM

Change 559515 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: move data type tracking into BRIDGE_INIT

https://gerrit.wikimedia.org/r/559515

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 20 2019, 4:01 PM
Lucas_Werkmeister_WMDE added a comment.Jan 7 2020, 12:00 PM

What’s the current status on cascade-protected messages? As far as I’m aware, the completion of T237526 is still blocked on them.

• Pablo-WMDE added a comment.Jan 7 2020, 3:54 PM

Observation: Devs during task break-down coined the term EditChoice. The product doc glossary already mentions "Edit decision" - we should decide for one or the other term to avoid confusion (especially as there already is the distinction from "Edit flow").

Lucas_Werkmeister_WMDE added a comment.Jan 8 2020, 11:03 AM

On client wikis, cascade protection doesn’t seem to be all that popular either. English Wikipedia has 124 cascade-protected pages that aren’t directly protected, none of them in the main namespace (Quarry); German Wikipedia has 1949 such pages, all of them in the project namespace (Quarry); Commons has 404 such pages, in the Project and File namespaces; on French, Russian and Basque Wikipedia, I found no such pages at all. If you also search pages that are otherwise protected, you find a grand total of six pages in the main namespace on English Wikipedia, and not much more on the other wikis I checked.

One example of pages protected via cascade protection on English Wikipedia are the “on this day” pages, e. g. Wikipedia:Selected anniversaries/January 8 (you’ll have to adjust the date if you want to see the cascade protection in action later).

gerritbot added a comment.Jan 8 2020, 11:25 AM

Change 562796 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] Remove IP address from i18n messages

https://gerrit.wikimedia.org/r/562796

Lucas_Werkmeister_WMDE mentioned this in T239801: Create EditDecision component.Jan 8 2020, 12:55 PM
gerritbot added a comment.Jan 9 2020, 12:18 PM

Change 562796 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove IP address from i18n messages

https://gerrit.wikimedia.org/r/562796

Charlie_WMDE updated the task description. (Show Details)Jan 9 2020, 12:51 PM

@Lucas_Werkmeister_WMDE @Tonina_Zhelyazkova_WMDE i added the mocks for the cascade protection to the task description. measurements etc can be found in the figma file under the same link as the other ones. If there's any questions, let me know!

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.15; 2020-01-14); removed MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Jan 9 2020, 1:00 PM
Lucas_Werkmeister_WMDE changed the status of subtask T237526: create messages according to mocks from Stalled to Open.Jan 9 2020, 3:18 PM
Charlie_WMDE added a comment.Jan 9 2020, 4:58 PM
NOTE: text of the cascade protection mocks was changed in the figma file. i have not updated the mocks in the ticket. please refer to the figma file for the newest copy. I will always give notice when text has been changed.
• Pablo-WMDE added a comment.Jan 10 2020, 10:41 AM

/cc @Lydia_Pintscher

Lucas_Werkmeister_WMDE closed subtask T237526: create messages according to mocks as Resolved.Jan 10 2020, 12:22 PM
• Pablo-WMDE updated the task description. (Show Details)Jan 13 2020, 2:09 PM
• Pablo-WMDE updated the task description. (Show Details)Jan 13 2020, 2:12 PM
Lucas_Werkmeister_WMDE closed subtask T241823: Dispatch combined permission service when application is started as Resolved.Jan 14 2020, 10:52 AM
darthmon_wmde added a project: Wikidata-Bridge-Sprint-12.Jan 15 2020, 10:03 AM
Lucas_Werkmeister_WMDE closed subtask T242413: Add ability to create article links to repo as Resolved.Jan 15 2020, 5:17 PM
Lucas_Werkmeister_WMDE closed subtask T237536: Wire up Permission Error Component in Error Component as Resolved.Jan 20 2020, 6:40 PM
Lucas_Werkmeister_WMDE closed subtask T237528: Create permission error component as Resolved.
Lucas_Werkmeister_WMDE reopened subtask T237528: Create permission error component as Open.Jan 20 2020, 6:42 PM
gerritbot added a comment.Jan 21 2020, 12:12 PM

Change 566258 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: remove resolved TODO from test

https://gerrit.wikimedia.org/r/566258

gerritbot added a comment.Jan 21 2020, 1:08 PM

Change 566258 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: remove resolved TODO from test

https://gerrit.wikimedia.org/r/566258

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.16; 2020-01-21); removed MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 21 2020, 2:00 PM
Lucas_Werkmeister_WMDE closed subtask T237528: Create permission error component as Resolved.Jan 22 2020, 11:44 AM
Charlie_WMDE closed subtask T243010: Hide save button if application is in error state as Resolved.Jan 22 2020, 1:43 PM
Lucas_Werkmeister_WMDE closed subtask T242832: Format user names in error messages as Resolved.Jan 22 2020, 2:56 PM
• Tonina_Zhelyazkova_WMDE claimed this task.Jan 22 2020, 5:17 PM
• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-12 board.
Lucas_Werkmeister_WMDE mentioned this in T243441: Reinstate standard styles for elements used in Data Bridge.Jan 22 2020, 6:29 PM
• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-12 board.Jan 23 2020, 10:38 AM
gerritbot added a comment.Jan 24 2020, 4:00 PM

Change 567089 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: refactor ErrorPermissionInfo

https://gerrit.wikimedia.org/r/567089

Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata-Bridge-Sprint-12 board.Jan 24 2020, 5:30 PM

Moving back to Doing because the only currently attached change is marked WIP in Gerrit, so I don’t see what I could review at the moment.

Lucas_Werkmeister_WMDE closed subtask T243230: Browser test permission violations as Resolved.Jan 24 2020, 5:31 PM
• Pablo-WMDE added a comment.Jan 27 2020, 4:35 PM

Intermediate state (how a repo item permission error currently looks like on my system) integrated into MW:

Bildschirmfoto von 2020-01-27 17-28-00.png (1×1 px, 346 KB)

Provisional list of todos:

  • "You do not have permission to edit this value, for the following reasons:"
    • vertical spacing
  • "More details" link
    • vertical spacing
    • might be bold in the mocks
  • "Why is this value protected?" / "What can I do?" headlines
    • vertical spacing
  • "Why is this value protected?" list
    • list-style-position, padding left
    • item vertical spacing
  • all links
    • link/hover color, text decoration
gerritbot added a comment.Jan 28 2020, 11:07 AM

Change 567876 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] ErrorPermission: fix content spacing

https://gerrit.wikimedia.org/r/567876

• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-13.Jan 28 2020, 12:18 PM
• Pablo-WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-13 board.
gerritbot added a comment.Jan 28 2020, 3:00 PM

Change 567089 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: refactor ErrorPermissionInfo

https://gerrit.wikimedia.org/r/567089

gerritbot added a comment.Jan 28 2020, 3:56 PM

Change 567876 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ErrorPermission: fix content spacing

https://gerrit.wikimedia.org/r/567876

Lucas_Werkmeister_WMDE moved this task from Doing to Verification on the Wikidata-Bridge-Sprint-12 board.Jan 28 2020, 5:17 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Verification on the Wikidata-Bridge-Sprint-13 board.
Charlie_WMDE added a comment.Jan 29 2020, 12:41 PM

how and where can I test the different options? I will probably also need to be blocked of repo/client to test the different versions

Lucas_Werkmeister_WMDE added a comment.EditedJan 29 2020, 1:21 PM

Notes from verification (subtasks to be created):

  • missing line-spacing on general “you can’t edit this value for the following reasons” message
  • cascade protected on client and repo has $2 in “administrators” link
  • we don’t load the mediawiki.jqueryMsg ResourceLoader module!
Charlie_WMDE added a comment.Jan 29 2020, 1:23 PM

image.png (450×500 px, 95 KB)

how it looks in my browser on german beta

Lucas_Werkmeister_WMDE added a comment.Jan 29 2020, 5:21 PM

I created three subtasks (Phabricator doesn’t show them here for some reason): T243917, T243918, T243919.

Lucas_Werkmeister_WMDE moved this task from Verification to To do on the Wikidata-Bridge-Sprint-13 board.Jan 29 2020, 5:21 PM
Lucas_Werkmeister_WMDE closed subtask T243919: mediawiki.jqueryMsg module not loaded as Resolved.Jan 30 2020, 10:52 AM
Lucas_Werkmeister_WMDE closed subtask T243917: Missing line-height on ErrorPermission heading as Resolved.
Lucas_Werkmeister_WMDE closed subtask T243918: $2 argument not provided in cascade-protected message on repo and client as Resolved.Jan 31 2020, 4:26 PM
Lucas_Werkmeister_WMDE moved this task from To do to Verification on the Wikidata-Bridge-Sprint-13 board.
Charlie_WMDE closed this task as Resolved.Feb 3 2020, 4:53 PM
Charlie_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-13 board.

looks good to me!\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits