[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T235944

Reduce number of modules registered by MassMessage
Closed, ResolvedPublic
Actions

Description

For context and rationale, see:

$ cat extension.json | jq '.ResourceModules | keys'
[
  "ext.MassMessage.autocomplete",
  "ext.MassMessage.content",
  "ext.MassMessage.content.js",
  "ext.MassMessage.content.noedit",
  "ext.MassMessage.content.nojs",
  "ext.MassMessage.create",
  "ext.MassMessage.edit",
  "ext.MassMessage.special",
  "ext.MassMessage.special.js"
]
Starting point
  1. ext.MassMessage.autocomplete (uses jquery.ui)
  2. ext.MassMessage.content (styles-only)
  3. ext.MassMessage.content.js (uses jquery.ui, and ext.MassMessage.autocomplete)
  4. ext.MassMessage.content.noedit (styles-only)
  5. ext.MassMessage.content.nojs (styles-only)
  6. ext.MassMessage.create (uses oojs-ui, and jquery.ui and ext.MassMessage.autocomplete)
  7. ext.MassMessage.edit (uses oojs-ui)
  8. ext.MassMessage.special (styles-only)
  9. ext.MassMessage.special.js (uses jquery.ui, and ext.MassMessage.autocomplete)
To do
  • Identify which distinct end-user scenarios MassMessage has resources for.
  • Determine how large the total payload from MassMessage for each of these scenarios is.
  • Determine which distinct deliverable bundles we need (possibly sharing one for several distinct use cases if overlap is significant and/or if overall size is small, e.g. under 3KB).
  • Combine modules into larger bundles and give name them accordingly where needed

Details

SubjectRepoBranchLines +/-
Convert modules to use packageFilesmediawiki/extensions/MassMessagemaster+75 -53
Move ext.MassMessage.styles files into a dedicated foldermediawiki/extensions/MassMessagemaster+6 -4
Merge style-only modules into ext.MassMessage.stylesmediawiki/extensions/MassMessagemaster+110 -84
ext.MassMessage.content.noedit: Remove redundant nojs.cssmediawiki/extensions/MassMessagemaster+1 -2
Remove `ext.MassMessage.autocomplete` modulemediawiki/extensions/MassMessagemaster+18 -10
Remove `ext.MassMessage.content.nojs` modulemediawiki/extensions/MassMessagemaster+8 -6
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Oct 19 2019, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2019, 8:23 PM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.Oct 19 2019, 8:23 PM
Krinkle added a project: Editing-team.
Krinkle added a subscriber: Legoktm.

Triaging based on mw:Maintainers.

Krinkle updated the task description. (Show Details)Oct 19 2019, 8:27 PM
DannyS712 subscribed.May 28 2020, 7:44 PM

onBeforePageDisplay hook handler is the only user of 4 distinct modules:

public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) {
	$title = $out->getTitle();
	if ( $title->exists() && $title->hasContentModel( 'MassMessageListContent' ) ) {
		$out->addModuleStyles( 'ext.MassMessage.content.nojs' );
		$permManager = MediaWikiServices::getInstance()->getPermissionManager();
		if ( $out->getRevisionId() === $title->getLatestRevId()
			&& $permManager->quickUserCan( 'edit', $out->getUser(), $title )
		) {
			$out->addModuleStyles( 'ext.MassMessage.content' );
			$out->addModules( 'ext.MassMessage.content.js' );
		} else {
			$out->addModuleStyles( 'ext.MassMessage.content.noedit' );
		}
	}
}

ext.MassMessage.content.nojs is defined as a single file, ext.MassMessage.content.nojs.css, which can simply be included in both the ext.MassMessage.content and ext.MassMessage.content.noedit modules rather than registered separately

gerritbot added a comment.May 28 2020, 7:46 PM

Change 599412 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Remove ext.MassMessage.content.nojs module

https://gerrit.wikimedia.org/r/599412

gerritbot added a project: Patch-For-Review.May 28 2020, 7:46 PM
DannyS712 added a comment.May 28 2020, 7:52 PM

The ext.MassMessage.autocomplete module is fairly simply, and is only used as a dependency by other modules that can simply include the underlying script themselves

gerritbot added a comment.May 28 2020, 7:52 PM

Change 599414 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Remove ext.MassMessage.autocomplete module

https://gerrit.wikimedia.org/r/599414

gerritbot added a comment.Jun 3 2020, 9:40 PM

Change 599412 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Remove ext.MassMessage.content.nojs module

https://gerrit.wikimedia.org/r/599412

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 3 2020, 10:00 PM
Krinkle added a comment.EditedJun 11 2020, 6:24 PM

Grafana graph.

Nice :)

DannyS712 added a project: User-DannyS712.Jun 11 2020, 6:28 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
Krinkle added a comment.Jun 25 2020, 9:38 PM

@DannyS712 As a possible next change, perhaps the three styles-only modules can be combined if they are not very large?

gerritbot added a comment.Jun 25 2020, 9:43 PM

Change 599414 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Remove ext.MassMessage.autocomplete module

https://gerrit.wikimedia.org/r/599414

DannyS712 added a comment.Jun 25 2020, 9:48 PM
In T235944#6258519, @Krinkle wrote:

@DannyS712 As a possible next change, perhaps the three styles-only modules can be combined if they are not very large?

Sure, though there will be a patch or two in the middle to help me wrap my head around the modules

gerritbot added a comment.Jun 25 2020, 9:50 PM

Change 607890 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] ext.MassMessage.content.noedit module: Don't include the nojs.css

https://gerrit.wikimedia.org/r/607890

gerritbot added a comment.Jun 25 2020, 9:58 PM

Change 607892 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Merge ext.MassMessage.content.nojs.css into content.css

https://gerrit.wikimedia.org/r/607892

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 25 2020, 10:00 PM
gerritbot added a comment.Jun 25 2020, 11:24 PM

Change 607890 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] ext.MassMessage.content.noedit: Remove redundant nojs.css

https://gerrit.wikimedia.org/r/607890

gerritbot added a comment.Jun 30 2020, 9:12 AM

Change 608474 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Convert ext.MassMessage.autocomplete.js to packageFiles

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/ /608474

gerritbot added a comment.Jul 1 2020, 11:45 PM

Change 607892 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Merge style-only modules into ext.MassMessage.styles

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/ /607892

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jul 2 2020, 12:00 AM
gerritbot added a comment.Sep 26 2021, 1:05 AM

Change 723702 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/MassMessage@master] Move ext.MassMessage.styles files into a dedicated folder

https://gerrit.wikimedia.org/r/723702

gerritbot added a comment.Oct 8 2021, 2:04 AM

Change 723702 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Move ext.MassMessage.styles files into a dedicated folder

https://gerrit.wikimedia.org/r/723702

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 8 2021, 3:00 AM
Nikerabbit subscribed.Dec 2 2021, 12:18 PM

Can someone update the current status, e.g. how much work is still expected to be done?

gerritbot added a comment.Dec 21 2021, 9:46 AM

Change 608474 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Convert modules to use packageFiles

https://gerrit.wikimedia.org/r/608474

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.16; 2022-01-03); removed MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Dec 21 2021, 10:00 AM
Nikerabbit moved this task from Backlog to Maintenance on the MassMessage board.Jan 26 2022, 9:23 AM
Krinkle closed this task as Resolved.Oct 3 2022, 9:55 PM
Krinkle assigned this task to DannyS712.
Krinkle triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits