Details
Related Objects
- Mentioned In
- T235959: Visual Editor: deleting selected text not working
T234817: Template context menu doesn't appear in some cases
T234742: TreeModifier: ensureNotText can return the wrong position
T215567: Split TreeModifier into a tree diff generator and tree diff applier - Mentioned Here
- T235959: Visual Editor: deleting selected text not working
T234881: TreeModifier: remover does not skip over a deleted node immediately following a text node
T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways
T215567: Split TreeModifier into a tree diff generator and tree diff applier
T234742: TreeModifier: ensureNotText can return the wrong position
T234817: Template context menu doesn't appear in some cases
rEVED011b6ebd6286: Update VE core submodule to 2ffb699eb (TreeModifier fixes)
rEVED11033b7d2ac4: ve.ui.MWDefinedTransclusionContextItem: Fix handling of template names
rGVED2ffb699ebed0: TreeModifier: Ignore more attributes when validating linear data
rGVED74bcce48e7e0: TreeModifier: Ignore more attributes when validating linear data
rGVED2c8e48194328: TreeModifier: Ignore more attributes when validating linear data
Event Timeline
On investigation, all subtasks are failing for precisely the same reason, so we should probably fold them into this task.
Change 541088 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] TreeModifier: Ignore more attributes when validating linear data
Change 541088 appears to fix every failure case given in the subtasks. (I loaded them all up on the live sites, in-browser patched the code, and cofirmed they no longer fail).
Change 541088 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TreeModifier: Ignore more attributes when validating linear data
Change 541272 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2c8e48194)
We'll deploy the fixes 3-4 hours from now (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20191007T1800).
Curses, I'll have gone to the pub by then :) any idea what caused the problem(s) originally?
Change 541272 merged by Bartosz Dziewoński:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2c8e48194)
Change 541299 had a related patch set uploaded (by Bartosz Dziewoński; owner: Divec):
[VisualEditor/VisualEditor@wmf/1.34.0-wmf.25] TreeModifier: Ignore more attributes when validating linear data
Change 541301 had a related patch set uploaded (by Bartosz Dziewoński; owner: Divec):
[VisualEditor/VisualEditor@REL1_34] TreeModifier: Ignore more attributes when validating linear data
Change 541303 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.25] Update VE core submodule to 2ffb699eb (TreeModifier fixes)
Change 541304 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@REL1_34] Update VE core submodule to 74bcce48e (TreeModifier fixes)
These are the backports for 1.34.0-wmf.25 (Wikimedia wikis version) and REL1_34 (upcoming stable MediaWiki release).
Change 541301 merged by jenkins-bot:
[VisualEditor/VisualEditor@REL1_34] TreeModifier: Ignore more attributes when validating linear data
Change 541299 merged by jenkins-bot:
[VisualEditor/VisualEditor@wmf/1.34.0-wmf.25] TreeModifier: Ignore more attributes when validating linear data
Change 541304 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@REL1_34] Update VE core submodule to 74bcce48e (TreeModifier fixes)
Change 541303 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.25] Update VE core submodule to 2ffb699eb (TreeModifier fixes)
Mentioned in SAL (#wikimedia-operations) [2019-10-07T18:25:08Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.25/extensions/VisualEditor/: SWAT: rEVED011b6ebd6286: rEVED11033b7d2ac4: Update VE core submodule to 2ffb699eb (TreeModifier fixes), T234489, T234742 + ve.ui.MWDefinedTransclusionContextItem: Fix handling of template names (T234817) (duration: 00m 53s)
We've recently rewritten (see T215567) a part of the "transaction processor", the system that remembers the changes you make in the document (so that you can undo/redo them, and so they can be restored in case of crashes). It turns out that the Cite extension (responsible for handling references) generates transactions in a slightly different way than we thought, which broke some assumptions in the new code and caused this problem.
Looks great, overall. I can still reproduce step 3 from T234142 with the following error:
load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:145 Uncaught Error: Remover and inserter unexpectedly diverged at VeDmTreeModifier.ve.dm.TreeModifier.processRetain (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:145) at VeDmTreeModifier.ve.dm.TreeModifier.processLinearOperation (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:143) at VeDmTreeModifier.ve.dm.TreeModifier.calculateTreeOperations (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:142) at VeDmTreeModifier.ve.dm.TreeModifier.process (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:142) at VeDmTransactionProcessor.ve.dm.TransactionProcessor.process (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:88) at VeDmDocument.ve.dm.Document.commit (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:209) at VeDmSurface.ve.dm.Surface.changeInternal (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:170) at VeDmSurface.ve.dm.Surface.change (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:170) at VeDmSurfaceFragment.ve.dm.SurfaceFragment.change (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:180) at VeDmSurfaceFragment.ve.dm.SurfaceFragment.delete (load.php?lang=en&modules=ext.visualEditor.core&skin=vector&version=1c46j:192)
I am still getting the following error with moving (drag-drop) and cutting references.
Check the screenshot for the error:
@matmarex: You're right. It was happening couple hours ago, but not anymore. Guess it was not updated at that point.
Would it be possible to have an description of the issue(s), so that community members can know what's going on? Thanks!
@Trizek-WMF The original issue (which should be resolved now) was that if you deleted, cut or moved a reference, the editor would stop responding to user actions.
The second issue (T234881, not resolved yet but in progress) is that if you delete, cut or move some text followed by a "node" (e.g. reference, comment, inline image), the editor stops responding to user actions.
It also appears when selecting text that includes a Citation in VE and pressing delete freezes VE
Apologies if I'm out of touch with recent events, but it seems it's still impossible to copy/cut/paste refs--and the text containing them--in VE. As of Right Now. Cheers, ~~~~
@Waddie96 @SerialNumber54129 I don't see this problem any more right now. I just tested on https://en.wikipedia.org/wiki/The_Fighting_Temeraire?veaction=edit and I was able to cut, paste or delete references, paragraphs, or even the entire article, and the editor was still responsive and the "Review your changes" dialog showed the expected results.
If you still see this problem, can you say which article and which reference in it are affected, and describe anything else you do to trigger it?
A new task T235959 was filed with the details of another case where deleting/cutting/moving a reference still doesn't work.