Steps to reproduce
- Export translations
- Add a translation
- Import translation
Expected result
- Successful changes reported (since the translations are indeed imported)
Actual result
- "There were no changes for this language" is reported
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Special:ImportTranslations: Avoid early processing of new translation | mediawiki/extensions/Translate | master | +12 -11 |
Event Timeline
Comment Actions
Yes, it did import the translations. This happened on both metawiki and mediawikiwiki
Comment Actions
It makes sense that the message appears after following the bug reproduction steps.
Importing the translation and clicking on 'Load file' button runs MessageWebImporter::execute()
- Once the file is loaded, the next UI shows the list of new messages (translations).
- But clicking on 'execute' runs MessageWebImporter::execute() again.
This call-stack suggests that the new messages will be imported [regardless] and saved before the messages are reviewed. Clicking 'execute' button which, I assume, is intended to allow the user to actually save the new messages after reviewing them, doesn't actually do what is intended of it. This issue might be bigger than just the message not showing correctly and is currently under investigation.
Comment Actions
Once they have reviewed their message, this is the feedback the user will receive .
The expected result is that unless the user clicks on the 'Execute' button, these translations are not saved.
When a user uploads their translations and clicks on 'load file' button, both the diff and 'new messages' will be shown (If the user has modified or added a new translation).
Once they have reviewed their message, this is the feedback the user will receive .
The expected result is that unless the user clicks on the 'Execute' button, these translations are not saved.
Comment Actions
Change 777349 had a related patch set uploaded (by Wangombe; author: Wangombe):
[mediawiki/extensions/Translate@master] Special:ImportTranslations: feedback message
Comment Actions
Work on this task was started a while back and it was not added to the Language team board. Adding it now since work is done on this.
Comment Actions
Change 777349 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Special:ImportTranslations: Avoid early processing of new translation