[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T145649

Deprecate and remove use of API action=purge with GET requests
Closed, ResolvedPublic
Actions

Description

T135170 initially wanted to do this, but for some reason ended up doing c84ba4d8 instead to make purging more complex and fragile. Let's do it for real.

Timeline:

  • 1.28: Update ApiPurge to emit a warning and log usage if used via GET
  • 1.28: Communicate the deprecation to the mediawiki-api-announce mailing list
  • 1.28/1.29: Review the usage statistics in Kibana, potentially alert high users directly
  • 1.29: Announce removal date to the mediawiki-api-announce mailing list
  • 1.29: Update ApiPurge to require POST
  • 1.29: If possible, revert c84ba4d8.

Details

SubjectRepoBranchLines +/-
Deprecate "Avoid page_touched update for HTTP GET action=purge requests"mediawiki/coremaster+35 -42
ApiPurge: Require POSTmediawiki/coremaster+2 -24
API: Deprecate use of ApiPurge via GETmediawiki/coremaster+18 -0
Customize query in gerrit

Related Objects

Event Timeline

Anomie created this task.Sep 14 2016, 3:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2016, 3:04 PM
gerritbot subscribed.Sep 14 2016, 3:06 PM

Change 310560 had a related patch set uploaded (by Anomie):
API: Deprecate use of ApiPurge via GET

https://gerrit.wikimedia.org/r/310560

gerritbot added a project: Patch-For-Review.Sep 14 2016, 3:06 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Sep 14 2016, 3:07 PM
gerritbot added a comment.Sep 14 2016, 4:37 PM

Change 310560 merged by jenkins-bot:
API: Deprecate use of ApiPurge via GET

https://gerrit.wikimedia.org/r/310560

Anomie updated the task description. (Show Details)Sep 14 2016, 4:44 PM
Anomie moved this task from Needs Review to Blocked on the MediaWiki-Action-API board.
Anomie removed a project: Patch-For-Review.
ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), MW-1.28-release-notes.Sep 14 2016, 5:00 PM
Anomie mentioned this in T146472: Investigate stopping logging api-feature-usage channel in Logstash.Sep 23 2016, 2:32 PM
Anomie mentioned this in T146526: Make ApiClearHasMsg require POST.Sep 24 2016, 11:25 AM
Anomie updated the task description. (Show Details)Dec 29 2016, 4:16 AM
gerritbot added a comment.Feb 1 2017, 3:36 PM

Change 335454 had a related patch set uploaded (by Anomie):
ApiPurge: Require POST

https://gerrit.wikimedia.org/r/335454

gerritbot added a project: Patch-For-Review.Feb 1 2017, 3:36 PM

Change 335455 had a related patch set uploaded (by Anomie):
Revert "Avoid page_touched update for HTTP GET action=purge requests"

https://gerrit.wikimedia.org/r/335455

Anomie moved this task from Blocked to Needs Review on the MediaWiki-Action-API board.Feb 1 2017, 3:40 PM
gerritbot added a comment.Feb 1 2017, 8:58 PM

Change 335454 merged by jenkins-bot:
ApiPurge: Require POST

https://gerrit.wikimedia.org/r/335454

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), MW-1.29-release-notes.Feb 1 2017, 9:00 PM
Anomie updated the task description. (Show Details)Feb 2 2017, 1:50 AM
Ricordisamoa subscribed.Feb 4 2017, 3:09 AM
gerritbot added a comment.Mar 28 2017, 11:32 PM

Change 335455 merged by jenkins-bot:
[mediawiki/core@master] Deprecate "Avoid page_touched update for HTTP GET action=purge requests"

https://gerrit.wikimedia.org/r/335455

Krinkle updated the task description. (Show Details)Mar 28 2017, 11:52 PM
ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)); removed MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)).Mar 29 2017, 12:00 AM
Anomie closed this task as Resolved.Mar 29 2017, 2:08 PM
Krinkle mentioned this in T150191: WikiPage::getLastPurgeTimestamp() returning an array.Apr 7 2017, 10:49 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Reedy mentioned this in T291316: 'purge' permission is not checked for action=purge.Sep 18 2021, 1:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits