Respect $wgAllowSiteCSSOnRestrictedPages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Porplemontage
	Jul 12 2016, 3:40 AM

Description

MediaWiki:Mobile.css is not loaded on the login, create account, or preferences pages. This produces an inconsistent interface on mobile for those with custom styling. On desktop, this problem is fixed by setting $wgAllowSiteCSSOnRestrictedPages to true. However, the value of $wgAllowSiteCSSOnRestrictedPages has no effect on mobile.

The value of $wgAllowSiteCSSOnRestrictedPages should be checked, and if true, then MediaWiki:Mobile.css should be loaded on the login, create account, and preferences special pages.

Details

	Subject	Repo	Branch	Lines +/-
	Remove mobile.site and mobile.styles modules	mediawiki/extensions/MobileFrontend	master	+49 -82
	Make $wgAllowSiteCSSOnRestrictedPages function properly on mobile	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T237050: The `site` and `site.styles` module should be explictly disabled on mobile rather than abuse the targets system
Mentioned Here: T65459: Allow configuration of the Minerva menu

Event Timeline

Porplemontage created this task.Jul 12 2016, 3:40 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 12 2016, 3:40 AM

Porplemontage triaged this task as Medium priority.Jul 12 2016, 3:41 AM

Jdlrobson raised the priority of this task from Medium to Needs Triage.Jul 12 2016, 8:45 PM

• Jhernandez added a project: Web-Team-Backlog.Jul 13 2016, 5:12 PM

Hi @Porplemontage what modifications are you trying to make to the mobile login and create account page? The preferences page is not exposed on the mobile site.

I used the MobileMenu hook to add a recent changes button to the menu, then used MediaWiki:Mobile.css to give it an icon. So the icon appears on every page but those special pages.

In addition, I wanted to make a few tweaks to the login and create account pages. Changes include increasing the size of the logo on the login page to match the create account page (the login page forces the image height to 72px while the create account page does not restrict it), changing the width of the create account form to 100% to match the login form, centering the logo on the create account page to match the login page, and hiding the create account benefits container so there's nothing below the create account button.

Thanks @Porplemontage for the quick response (sorry mine is slower). Sadly menu configuration (T65459) and skin customisations are not as easy as they should be :/

Ideally you should not need to use CSS to configure the menu/

Jdlrobson triaged this task as Low priority.Jul 21 2016, 8:27 PM

Jdlrobson added a project: good first task.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 21 2016, 8:27 PM

• jhobs moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 21 2016, 8:27 PM

Jdlrobson added a project: Reading-Web-Third-Party-Support.May 21 2017, 1:00 PM

Jdlrobson added a project: patch-welcome.Jul 10 2017, 10:32 PM

Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Aug 24 2017, 6:02 PM

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

Jdlrobson moved this task from Untriaged to Discuss further on the Web-Team-Backlog (Tracking) board.Aug 24 2017, 6:35 PM

Jdlrobson added a project: Google-Code-in-2019.Oct 23 2019, 4:59 PM

Imported into GCI site as https://codein.withgoogle.com/tasks/5691696369631230/

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Oct 29 2019, 7:36 PM

tabish.shaikh91 subscribed.Dec 11 2019, 5:22 AM

Sorry, forgot to claim this on Phabricator when I claimed it on GCI yesterday.

Restricted Application added a subscriber: RhinosF1. · View Herald TranscriptDec 19 2019, 9:48 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q2); removed Web-Team-Backlog (Tracking).Dec 19 2019, 9:50 PM

Change 559606 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/MobileFrontend@master] Make $wgAllowSiteCSSOnRestrictedPages function properly on mobile

https://gerrit.wikimedia.org/r/559606

gerritbot added a project: Patch-For-Review.Dec 19 2019, 9:50 PM

Jdlrobson moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 19 2019, 9:51 PM

Pppery removed Pppery as the assignee of this task.Dec 20 2019, 10:31 PM

Change 559606 abandoned by Pppery:
Make $wgAllowSiteCSSOnRestrictedPages function properly on mobile

https://gerrit.wikimedia.org/r/559606

Maintenance_bot removed a project: Patch-For-Review.Dec 20 2019, 11:10 PM

Jdlrobson moved this task from Doing to Needs Analysis on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Jan 6 2020, 6:12 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q3); removed Web-Team-Backlog (Kanbanana-2019-20-Q2).Jan 6 2020, 7:04 PM

Change 562380 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove mobile.site and mobile.styles modules

https://gerrit.wikimedia.org/r/562380

gerritbot added a project: Patch-For-Review.Jan 7 2020, 12:37 AM