The rest of the vmsplice() exploit story
The rest of the vmsplice() exploit story
Posted Mar 5, 2008 12:32 UTC (Wed) by Los__D (guest, #15263)In reply to: The rest of the vmsplice() exploit story by epa
Parent article: The rest of the vmsplice() exploit story
Heh, you've got good eyes! :)
Posted Mar 5, 2008 14:00 UTC (Wed)
by jzbiciak (guest, #5246)
[Link] (2 responses)
Ironically, "break;" is the only correctly indented line in that loop body. (That is, if you go with the Linux kernel standard 8 character indent.)
Posted Mar 5, 2008 14:48 UTC (Wed)
by corbet (editor, #1)
[Link] (1 responses)
As for indent depth, I routinely shorten it in code samples to make the result fit in the browser window. The original code uses full-tab indents.
Posted Mar 5, 2008 19:14 UTC (Wed)
by jzbiciak (guest, #5246)
[Link]
The rest of the vmsplice() exploit story
The indentation of the break line was clearly wrong (and different from the real code), I fixed it.
Indentation
Indentation
I did notice the consistent 4-character indents elsewhere. I was being a tad tongue-in-cheek
because of the apparent irony. (It was clear that the 'break' statement was the odd man out.)
Cheers,
--Joe