netdev - RE: [PATCH] net: ethernet: mtk-star-emac: Use of_get_available_child_by

More Web Proxy on the site http://driver.im/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB113468F3BEBEC430687B060FB86EA2@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sun, 2 Feb 2025 10:14:32 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Felix Fietkau <nbd@....name>, Sean Wang <sean.wang@...iatek.com>, Lorenzo
 Bianconi <lorenzo@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger
	<matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, Geert Uytterhoeven
	<geert+renesas@...der.be>, biju.das.au <biju.das.au@...il.com>
Subject: RE: [PATCH] net: ethernet: mtk-star-emac: Use
 of_get_available_child_by_name()

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: 01 February 2025 18:47
> Subject: Re: [PATCH] net: ethernet: mtk-star-emac: Use of_get_available_child_by_name()
> 
> On Sat, Feb 01, 2025 at 04:21:32PM +0000, Biju Das wrote:
> > Use the helper of_get_available_child_by_name() to simplify
> > mtk_star_mdio_init().
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > ---
> > This patch is only compile tested and depend upon[1] [1]
> > https://lore.kernel.org/all/20250201093126.7322-1-biju.das.jz@bp.renes
> > as.com/
> > ---
> >  drivers/net/ethernet/mediatek/mtk_star_emac.c | 24
> > ++++---------------
> >  1 file changed, 5 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> > b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> > index 25989c79c92e..beb0500fe9d5 100644
> > --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> > +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> > @@ -1422,25 +1422,15 @@ static int mtk_star_mdio_init(struct
> > net_device *ndev)  {
> >  	struct mtk_star_priv *priv = netdev_priv(ndev);
> >  	struct device *dev = mtk_star_get_dev(priv);
> > -	struct device_node *of_node, *mdio_node;
> > -	int ret;
> > -
> > -	of_node = dev->of_node;
> > +	struct device_node *mdio_node _free(device_node) =
> > +		of_get_available_child_by_name(dev->of_node, "mdio");
> 
> Same comment as for you other similar patch.

Ok, Will send next version with readable code once
dependency patch hits on net-next.

Cheers,
Biju