8000 chore: fix up the developing page links by kelsin · Pull Request #547 · 18xx-maker/18xx-maker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix up the developing page links #547

Merged
merged 1 commit into from
Nov 24, 2024
Merged

chore: fix up the developing page links #547

merged 1 commit into from
Nov 24, 2024

Conversation

kelsin
Copy link
Collaborator
@kelsin kelsin commented Nov 24, 2024

No description provided.

@kelsin kelsin enabled auto-merge November 24, 2024 21:02
@netlify Netlify
Copy link
netlify bot commented Nov 24, 2024 •
edited
Loading

✅ Deploy Preview for 18xx-maker ready!

Name Link
🔨 Latest commit 1a73727
🔍 Latest deploy log https://app.netlify.com/sites/18xx-maker/deploys/6743946b4aa74a0008e40636
😎 Deploy Preview https://deploy-preview-547--18xx-maker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link
netlify bot commented Nov 24, 2024 8000 •
edited
Loading

✅ Deploy Preview for 18xx-maker-storybook ready!

Name Link
🔨 Latest commit 1a73727
🔍 Latest deploy log https://app.netlify.com/sites/18xx-maker-storybook/deploys/6743946be7dc860008a39937
😎 Deploy Preview https://deploy-preview-547--18xx-maker-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link
codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 66.76%. Comparing base (ce472b0) to head (1a73727).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/Docs.jsx 74.28% 7 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   66.75%   66.76%   +0.01%     
==========================================
  Files         176      176              
  Lines       15865    15879      +14     
  Branches     1583     1583              
==========================================
+ Hits        10591    10602      +11     
- Misses       3725     3728       +3     
  Partials     1549     1549

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% (target: -1.00%) ✅ 80.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ce472b0) 15865 12120 76.39%
Head commit (1a73727) 15879 (+14) 12131 (+11) 76.40% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#547) 35 28 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov Codecov
Copy link
codecov bot commented Nov 24, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 2.29kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
18xx-maker-esm 20.26MB 627 bytes (0.0%) ⬆️
18xx-maker-renderer-esm 21.6MB 1.67kB (0.01%) ⬆️

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11999553043

Details

  • 28 of 35 (80.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 76.074%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/Docs.jsx 28 35 80.0%
Files with Coverage Reduction New Missed Lines %
src/pages/Docs.jsx 1 84.28%
Totals Coverage Status
Change from base Build 11999512913: 0.002%
Covered Lines: 12131
Relevant Lines: 15879
💛 - Coveralls

@kelsin kelsin added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit 56f2009 Nov 24, 2024
14 checks passed
@kelsin kelsin deleted the clean-docs branch November 24, 2024 21:11
@kelsin kelsin mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelsin @coveralls
0