Comparing changes
Open a pull request
- 11 commits
- 9 files changed
- 1 contributor
Commits on Jul 11, 2024
-
require indifferent_access extension explicitly
In the model-to-mixin rework for Arturo 3.0, we changed the load order, and this extension might not always get loaded before the `FeatureMethods` module. This doesn’t happen in Arturo’s own tests, but affects gems that depend on Arturo.
-
-
use original checkout and setup-ruby actions
Instead of Zendesk forks which are not maintained anymore, as we have switched to a different security model for shared Github workflows.
-
We have removed bump as a dependency in e644d05, but still required it in the `Rakefile` which caused all rake tasks to fail.
-
clear whitelists and blacklists after running their specs
The 'works with a post on holds' spec in controller_filters_spec.rb was flaky. In it, we check that if a feature :book_holds has deployment_percentage set to 0, and we call require_feature :book_holds in a controller, then we receive 403 Forbidden from that controller. However, if the 'works with global whitelisting' spec ran as a final spec from its suite of six, and before the :book_holds, we still had a whitelist in place that would enable all features, so enabled_for? returned true for :book_holds: def enabled_for?(feature_recipient) return false if feature_recipient.nil? return false if blacklisted?(feature_recipient) ---> return true if whitelisted?(feature_recipient) # returned true, so we never checked deployment_percentage passes_threshold?(feature_recipient, deployment_percentage || 0) end This suggests that approximately 1/12 of all spec runs should see this spec fail (the probability of the global whitelist spec being last is 1/6, and the probability of it running before the controller spec is 1/2), which agrees with the recent data: in a matrix of 16, one job was usually failing. The solution to this problem is to clean whitelists (and blacklists) not only before their specs, but also after.
-
stop checking for before_filter
`before_filter` got deprecated in Rails 5.1, and we only support Rails 6.0 and above, so there is no need to check whether we need it or `before_action`.
Commits on Jul 12, 2024
-
Merge pull request #153 from zendesk/jury.razumau/before_filter
stop checking for before_filter
-
Merge pull request #152 from zendesk/jury.razumau/controllers_flaky_spec
clear whitelists and blacklists after running their specs
-
Merge pull request #151 from zendesk/jury.razumau/bump_removal
stop requiring bump
-
Merge pull request #150 from zendesk/jury.razumau/switch_ci_actions
use original checkout and setup-ruby actions
-
Merge pull request #149 from zendesk/jury.razumau/indifferent_access
require indifferent_access extension explicitly
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.1.0...v4.1.1