[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _data/sites/*.js "default" files from repository for easer fork install/update #37

Open
nhoizey opened this issue Dec 23, 2020 · 5 comments
Open

Remove _data/sites/*.js "default" files from repository for easer fork install/update #37

nhoizey opened this issue Dec 23, 2020 · 5 comments

Comments

@nhoizey
Copy link
Contributor
nhoizey commented Dec 23, 2020

Every time I try to update my fork, I get back the _data/sites/*.js from this repository, and most of the times, I forgot to remove them and have (at least) one big build on Netlify. 😅

It would be easier if these files where in a _data/sites-sample/ folder, and speedlify would alert if there is no _data/sites/*.js yet.

You @zachleat could then copy _data/sites-sample/ to _data/sites/ in your own fork running on Netlify.

It would be much easier for anyone else using speedlify for their own needs, but I agree it would be less easy for you @zachleat to manage both this and a fork, though. 🤷‍♂️
@TigersWay
Copy link

I thought skip: !process.env.CONTEXT || process.env.SITE_NAME !== "speedlify" was there just for that purpose...

@nhoizey
Copy link
Contributor Author
nhoizey commented Dec 23, 2020

Hum… my process must be broken then, I'll try once again and report if this work as intended!

@nhoizey
Copy link
Contributor Author
nhoizey commented Dec 23, 2020

Ok, I think my fork update was a little too extreme, it removed my own personal sites configurations… 🤦‍♂️

How do you update yours?

I was also reading "After cloning you’ll probably want to delete the initial _data/sites/*.js files and create your own file with a list of your own site URLs!" in the README and jumped to a bad conclusion.

@TigersWay
Copy link

All _data/sites/*.js but the sample one have that skip flag... I believe I used that one the first time 😄
Then I added new ones. @zachleat's original files are still there.

@nhoizey
Copy link
Contributor Author
nhoizey commented Dec 23, 2020

Looks like you're right, the "The default sites that get tested" is active by default, we have to remove it:
https://webperf-monitoring.netlify.app/

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhoizey @TigersWay