8000 Encryption algorithm AES/ECB/NoPadding is broken and not secure · Issue #1 · zx63/TronWallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Encryption algorithm AES/ECB/NoPadding is broken and not secure #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
luchua-bc opened this issue Dec 16, 2020 · 0 comments
Open

Encryption algorithm AES/ECB/NoPadding is broken and not secure #1

luchua-bc opened this issue Dec 16, 2020 · 0 comments

Comments

@luchua-bc
Copy link

Hi @zx63,

Thanks for sharing the repository and it's a nice one.

I noticed one issue - the src/main/java/org/tron/common/crypto/SymmEncoder.java class uses AES/ECB/NoPadding as the AES encryption/decryption algorithm. However, the ECB mode is not secure since it's vulnerable to reply attacks.

A modern algorithm like AES/GCM/NoPadding is preferred as shown in the Java 11 JSEE Guide.

Please consider to replace the broken crypto algorithm with a stronger one.

Thanks,
@luchua-bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luchua-bc
0