Question about why return 204 NO_Content when doing update #3007
-
|
Hi, Expected BehaviorGiven (update data-type/1) Return (Body after updating): Current BehaviorGiven (update data-type/1) Return (Body after updating): Possible Solutionwhen construct the patch response, is it possible to let end user decide to return response or not? ContextI am in a context of building a CRUD admin api. And I need to present the response (entity after updating) to client. Although I have the option to call /Get api after updating, reading the response after update would make work easier. Because I don't need to call extra apis. Your Environment
|
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
|
you can use this method while building the ElideSettings. https://github.com/yahoo/elide/blob/master/elide-core/src/main/java/com/yahoo/elide/ElideSettingsBuilder.java#L182 |
Beta Was this translation helpful? Give feedback.
-
|
Thank you, that is really helpful. I think it would be nice to add how to override ElideSetting into the Elide documentation |
Beta Was this translation helpful? Give feedback.
-
|
@pagexv could you please help me out how did you overside ElideSetting . What changes you made. |
Beta Was this translation helpful? Give feedback.
-
|
Currently in order to change the behavior you need to create a fully configured package example;
import java.util.TimeZone;
import org.apache.commons.lang3.StringUtils;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import com.yahoo.elide.Elide;
import com.yahoo.elide.ElideSettingsBuilder;
import com.yahoo.elide.RefreshableElide;
import com.yahoo.elide.core.TransactionRegistry;
import com.yahoo.elide.core.audit.Slf4jLogger;
import com.yahoo.elide.core.datastore.DataStore;
import com.yahoo.elide.core.dictionary.EntityDictionary;
import com.yahoo.elide.core.exceptions.ErrorMapper;
import com.yahoo.elide.core.filter.dialect.RSQLFilterDialect;
import com.yahoo.elide.jsonapi.JsonApiMapper;
import com.yahoo.elide.jsonapi.links.DefaultJSONApiLinks;
import com.yahoo.elide.spring.config.ElideConfigProperties;
import com.yahoo.elide.utils.HeaderUtils;
@Configuration
public class ElideConfiguration {
@Bean
public RefreshableElide refreshableElide(EntityDictionary dictionary, DataStore dataStore,
HeaderUtils.HeaderProcessor headerProcessor, TransactionRegistry transactionRegistry,
ElideConfigProperties settings, JsonApiMapper mapper, ErrorMapper errorMapper) {
ElideSettingsBuilder builder = new ElideSettingsBuilder(dataStore)
.withUpdate200Status()
.withEntityDictionary(dictionary)
.withErrorMapper(errorMapper).withJsonApiMapper(mapper)
.withDefaultMaxPageSize(settings.getMaxPageSize()).withDefaultPageSize(settings.getPageSize())
.withJoinFilterDialect(RSQLFilterDialect.builder().dictionary(dictionary).build())
.withSubqueryFilterDialect(RSQLFilterDialect.builder().dictionary(dictionary).build())
.withAuditLogger(new Slf4jLogger()).withBaseUrl(settings.getBaseUrl())
.withISO8601Dates("yyyy-MM-dd'T'HH:mm'Z'", TimeZone.getTimeZone("UTC"))
.withHeaderProcessor(headerProcessor);
if (settings.isVerboseErrors()) {
builder.withVerboseErrors();
}
if (settings.getAsync() != null && settings.getAsync().getExport() != null
&& settings.getAsync().getExport().isEnabled()) {
builder.withExportApiPath(settings.getAsync().getExport().getPath());
}
if (settings.getGraphql() != null && settings.getGraphql().isEnabled()) {
builder.withGraphQLApiPath(settings.getGraphql().getPath());
if (settings.getGraphql().getFederation().isEnabled()) {
builder.withGraphQLFederation(true);
}
}
if (settings.getJsonApi() != null && settings.getJsonApi().isEnabled()) {
builder.withJsonApiPath(settings.getJsonApi().getPath());
if (settings.getJsonApi().getLinks().isEnabled()) {
String baseUrl = settings.getBaseUrl();
if (StringUtils.isEmpty(baseUrl)) {
builder.withJSONApiLinks(new DefaultJSONApiLinks());
} else {
String jsonApiBaseUrl = baseUrl + settings.getJsonApi().getPath() + "/";
builder.withJSONApiLinks(new DefaultJSONApiLinks(jsonApiBaseUrl));
}
}
}
Elide elide = new Elide(builder.build(), transactionRegistry, dictionary.getScanner(), true);
return new RefreshableElide(elide);
}
} |
Beta Was this translation helpful? Give feedback.
you can use this method while building the ElideSettings. https://github.com/yahoo/elide/blob/master/elide-core/src/main/java/com/yahoo/elide/ElideSettingsBuilder.java#L182