8000 XsdParser::getSchemaNode fails with comments · Issue #7 · xmlet/XsdParser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

XsdParser::getSchemaNode fails with comments #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skfcz opened this issue May 12, 2019 · 3 comments
Closed

XsdParser::getSchemaNode fails with comments #7

skfcz opened this issue May 12, 2019 · 3 comments

Comments

@skfcz
Copy link
skfcz commented May 12, 2019

Hello,

currently XsdParser uses doc.getFirstChild(); to get the XSD root.
This fails terribly with all kinds of schema which have a comment or text node.

My proposal is to use

return doc.getDocumentElement();

Bye, Carsten

@lcduarte
Copy link
Member

Hi,

Thanks for the note. I'll introduce that fix with the next release once another feature is requested. I've taken that approach since the XSD documentation states that the xsd:schema should always be the first node of a XSD document, but in any case I'll introduce that fix to prevent any bugs with files that contain comments before the xsd:schema node.

Thank you again.

Regards,
Luís

@skfcz
Copy link
Author
skfcz commented May 21, 2019 via email

@lcduarte
Copy link
Member
lcduarte commented Jun 9, 2019

Hello,

In 1.0.17 this issue is resolved.

I'll close this issue, open another if you get any other problem.

Regards,
Luís

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
0