8000 Library incorrectly pads small packets · Issue #23 · xmos/lib_xtcp · GitHub

More Web Proxy on the site http://driver.im/

Library incorrectly pads small packets #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

pthedinger opened this issue Jan 4, 2017 · 2 comments

pthedinger commented

In xcoredev.xc, lines 100-103 it incorrectly uses 64 bytes as the minimum packet size and pads:

    if (len < 64)  {
      for (int i=len;i<64;i++)
        (uip_buf32, unsigned char[])[i] = 0;
      len=64;
    }

This should be 60, as the CRC will be automatically added to make the size up to the minimum frame size of 64 bytes.

The text was updated successfully, but these errors were encountered:

ahogen commented

Fixed in commit ed83ea5

Contributor

samchesney commented

Thank you @ahogen.

Closing as fix this is fixed on master.

samchesney closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0