8000 Implement product prices caching · Issue #27 · xmobile-atamyrat/xmobile-v1 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement product prices caching #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
Babahan-0906 opened this issue Jan 21, 2025 · 3 comments
Closed
1 task done

Implement product prices caching #27

Babahan-0906 opened this issue Jan 21, 2025 · 3 comments
Assignees
@Babahan-0906
Labels
High priority

Comments

@Babahan-0906
Copy link
Collaborator
Babahan-0906 commented Jan 21, 2025 •
edited
Loading
  • product prices
@Babahan-0906 Babahan-0906 self-assigned this Jan 26, 2025
@Babahan-0906 Babahan-0906 reopened this Apr 3, 2025
@Intizar-T
Copy link
Contributor

@Babahan-0906 any idea if this is about caching product detail prices?

@Intizar-T Intizar-T changed the title Implement caching Implement product prices caching May 14, 2025
@Babahan-0906
Copy link
Collaborator Author

I think we're already caching both the product prices and product detail prices in sessionStorage.
In utils.ts, there are two functions — computeProductPriceTags (for product details) and computeProductPrice (for general product prices). Both end up calling computePrice, which checks sessionStorage first, then falls back to the database.

as far as I recall, I opened this pr from TODO LIST.txt that we had back in december, and from what i understood, this PR was opened to explore general caching improvements. and when caching should be manual sessionstorage based caching (like this one) or third-party caching. Please let me know if I’m missing anything here!

@Intizar-T
Copy link
Contributor

I think we're already caching both the product prices and product detail prices in sessionStorage. In utils.ts, there are two functions — computeProductPriceTags (for product details) and computeProductPrice (for general product prices). Both end up calling computePrice, which checks sessionStorage first, then falls back to the database.

as far as I recall, I opened this pr from TODO LIST.txt that we had back in december, and from what i understood, this PR was opened to explore general caching improvements. and when caching should be manual sessionstorage based caching (like this one) or third-party caching. Please let me know if I’m missing anything here!

Ah yes I just confirmed both prices get cached in session storage. I guess then this issue can be closed. We can open a new one if there is need for further caching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Babahan-0906 Babahan-0906

Labels
High priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Intizar-T @Babahan-0906
0