8000 Player::StopNote should take note parameter from MidiInDevice · Issue #508 · xiphonics/picoTracker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Player::StopNote should take note parameter from MidiInDevice #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chrcav opened this issue Apr 29, 2025 · 2 comments
Open

Player::StopNote should take note parameter from MidiInDevice #508

chrcav opened this issue Apr 29, 2025 · 2 comments
Assignees
@maks
Labels
bug Something isn't working midi concerns midi input/output
Milestone
2.1

Comments

@chrcav
Copy link
Contributor
chrcav commented Apr 29, 2025

Right now if using a keyboard and holding multiple keys any of the key releases send a Midi Note Off and kill the playing note even if the note being played is still held down. At least for me this causes notes that I play in a sequence to get cut off if I'm not careful to fully release a key before pressing a new one.
@chrcav
Copy link
Contributor Author
chrcav commented Apr 29, 2025

It seems safe to just add the note to Player::StopNote() since it's only called in MidiInDevice. From there calling PlayerMixer::GetChannelNote() to compare to the note parameter before calling PlayerMixer::StopInstrument().

Are there any concerns with this approach that I'm missing?

@maks maks self-assigned this Apr 29, 2025
@maks maks added bug Something isn't working midi concerns midi input/output labels Apr 29, 2025
@maks maks added this to the 2.1 milestone Apr 29, 2025
@maks
Copy link
Collaborator
maks commented Apr 29, 2025

Thanks for spotting this issue @chrcav 👍🏻

I'm not sure though about what you're suggesting. We do 💯 need to track currently playing notes to fix this but I think this is rather something that should be handled by MidiInDevice::treatChannelEvent()

Also I had in mind to enable chromatic polyphonic playback in future (though only single not multi-timbral) so need to keep that in mind while working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maks maks

Labels
bug Something isn't working midi concerns midi input/output
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@maks @chrcav
0