8000 Performance regression with 1.1.10.4? · Issue #542 · xerial/snappy-java · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Performance regression with 1.1.10.4? #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
whenamanlies opened this issue Dec 7, 2023 · 5 comments
Open

Performance regression with 1.1.10.4? #542

whenamanlies opened this issue Dec 7, 2023 · 5 comments

Comments

@whenamanlies
Copy link

We are moving from 1.1.10.3 to 1.1.10.4 (for CVE-2023-43642) and observing performance regressions (reading parquet, if that's important). Anyone else observing similar?

Wonder if there's a tie to snappy's upgrade from 1.1.8 to 1.1.10.
Snappy project has been quiet lately however there's at least one similar report in snappy-compression Google Group.
@xerial
Copy link
Owner
xerial commented Dec 7, 2023 •
edited
Loading

Since https://github.com/xerial/snappy-java/releases/tag/v1.1.10.4, the internal snappy version has upgraded to snappy 1.1.10. Until snappy-java 1.1.10.3, snappy 1.1.8 was unexpectedly used.

If the original Snapy 1.1.10 has performance regression, it should be the cause. The CVE fix looks unrelated as Parquet-mr is not using SnappyInput/OutputStream as far as I know.

@whenamanlies
Copy link
Author

Agree it is not a CVE fix.

@xerial have a communication channel with @pwnall?

@xerial
Copy link
Owner
xerial commented Dec 11, 2023

@whenamanlies No. The best way is to report the regression at snappy https://github.com/google/snappy and fix it there.

@findmenowhere
Copy link

Hello @whenamanlies, we recently had the same issue, and the Google Group has been banned. Have you reached any conclusions?

@findmenowhere
Copy link

@xerial Also do we mind upgrading the internal snappy version to 1.2.x in order to verify if the regression is already fixed in the newer version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xerial @whenamanlies @findmenowhere
0