8000 BitShuffle#shuffle does not allow to pass arbitrary type sizes (even if the underlying library does support that) · Issue #298 · xerial/snappy-java · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BitShuffle#shuffle does not allow to pass arbitrary type sizes (even if the underlying library does support that) #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
foosmate opened this issue Nov 10, 2021 · 1 comment
Open

BitShuffle#shuffle does not allow to pass arbitrary type sizes (even if the underlying library does support that) #298

foosmate opened this issue Nov 10, 2021 · 1 comment
Labels
help wanted

Comments

@foosmate
Copy link
foosmate commented Nov 10, 2021 •
edited
Loading

For data encoding, sometimes integers with intermediate sizes (e.g. of 3 or 5 bytes) are used (e.g. to reduce bandwith). These arrays currently cannot be passed to the external BitShuffle library with snappy-java, because in snappy-java the typesize is predefined as constant. Since the external library actually supports arbitrary type sizes this is an unnecessary restriction.

How to fix:

Would be great to have the following methods:

public static int shuffle(ByteBuffer input, int typeSize, ByteBuffer shuffled) throws IOException {
    ...
}

public static int unshuffle(ByteBuffer shuffled, int typeSize, ByteBuffer output) throws IOException {
    ...
}
@foosmate foosmate mentioned this issue Nov 10, 2021
Closed
@xerial
Copy link
Owner
xerial commented May 23, 2023

Related #443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xerial @foosmate
0