From a8f99be06c1115c4d6a324b5471784f6dbec5dab Mon Sep 17 00:00:00 2001 From: Songmu Date: Tue, 25 Mar 2025 23:15:39 +0900 Subject: [PATCH] =?UTF-8?q?Make=20the=20NO=5FCOLOR=20environment=20variabl?= =?UTF-8?q?e=20accept=20strings=20other=20than=20the=20=E2=80=9Ctrue?= =?UTF-8?q?=E2=80=9D=20sings?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- logger/log.go | 10 +++------- logger/log_test.go | 4 ++-- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/logger/log.go b/logger/log.go index 63ae860..76bf663 100644 --- a/logger/log.go +++ b/logger/log.go @@ -4,7 +4,6 @@ import ( "fmt" "io" "os" - "strings" "github.com/motemen/go-colorine" ) @@ -51,16 +50,13 @@ var ( ) func init() { - SelectLogger() + selectLogger() } -func SelectLogger() { - v := os.Getenv("NO_COLOR") - - if strings.ToLower(v) == "true" { +func selectLogger() { + if os.Getenv("NO_COLOR") != "" { logger = loggerWithoutColor } - SetOutput(os.Stderr) } diff --git a/logger/log_test.go b/logger/log_test.go index cc6f07c..9cec628 100644 --- a/logger/log_test.go +++ b/logger/log_test.go @@ -8,7 +8,7 @@ import ( func TestLog(t *testing.T) { t.Run("with color", func(t *testing.T) { t.Logf("NO_COLOR: %s", os.Getenv("NO_COLOR")) - SelectLogger() + selectLogger() // info Log("default", "should be green") // verbose @@ -25,7 +25,7 @@ func TestLog(t *testing.T) { t.Run("without color", func(t *testing.T) { t.Setenv("NO_COLOR", "true") t.Logf("NO_COLOR: %s", os.Getenv("NO_COLOR")) - SelectLogger() + selectLogger() // info Log("default", "should be none") // verbose