8000 Rollup can't interpret annotation "/*#__PURE__*/" · Issue #50 · wevm/ox · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rollup can't interpret annotation "/*#__PURE__*/" #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
silverpill opened this issue Jan 11, 2025 · 5 comments
Closed
1 task done

Rollup can't interpret annotation "/*#__PURE__*/" #50

silverpill opened this issue Jan 11, 2025 · 5 comments
Labels
M: Needs Reproduction Misc: Needs Reproduction

Comments

@silverpill
Copy link

Check existing issues

Ox Version

0.6.0

Current Behavior

A warning is generated when the module is processed with Rollup:

node_modules/viem/node_modules/ox/_esm/core/Json.js (1:21): A comment

"/*#__PURE__*/"

in "node_modules/viem/node_modules/ox/_esm/core/Json.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

Apparently this annotation is supposed to be used with functions, but here it is used with a constant.

Expected Behavior

No warning.

Steps To Reproduce

  1. Add viem to a project that uses Rollup.
  2. Build it

Link to Minimal Reproducible Example

No response

Anything else?

Rollup v4.24.1
@jxom
Copy link
Member
jxom commented Jan 11, 2025

Need a minimal repro please

@jxom jxom added the M: Needs Reproduction Misc: Needs Reproduction label Jan 11, 2025
@paro-paro
Copy link

@jxom here is a minimal repro

A few more errors are thrown in the repro but only the one reported in this issue is the one that's affecting me in a real vue application (where I am using the @wagmi/vue package).

Thanks in advanced.

P.S. Vue applications are built using vite, which uses rollup under the hood for production bundles.

@jxom
Copy link
Member
jxom commented Jan 20, 2025

Let me know if it is fixed now.

@jxom jxom closed this as completed Jan 20, 2025
@silverpill
Copy link
Author

Thanks @paro-paro and @jxom
The warning disappeared after updating to v0.6.7

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 5, 2025

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Ox version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
M: Needs Reproduction Misc: Needs Reproduction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jxom @paro-paro @silverpill
0