Description
Could potentially cause bugs and blocks: #218
We have regular opening hours for all venues. Should those change, an instance of a "modified opening time" is added:
- If it is an exceptional close (e.g. on a day the venue is usually open), a date is added without any times, so the "opens" and "closes" fields are left empty
- If it is an exceptional open (e.g. the Gallery on Mondays is closed, but not during bank holiday Mondays), a date is added WITH times.
The Venues API was mostly built for the Deepstore and Library venues, and it was considered at the time that "modified opening times" meant closures only. Therefore, the logic currently only adds all "modified opening times" to the "exceptional closures" list, without considering whether or not they could be exceptional opens.
This could be a problem should they start wanting exceptional opens, but also stops us from using the venues API on a bigger scale, such as in the Events filters, or the footer opening times.
This tickets serves to ensure exceptional closures only returns closures, and a new "exceptional opens" (or "modified opening hours"?) is returned from the API, with the hours included.
This could affect the requesting item service and therefore the work should ensure it does not.
There could also be a question of "should it be made clearer within Prismic itself"? The only way to differentiate a special closure from an special opening is whether or not it has hours, is that clear enough? Should more be made available to the Collection venue model?
Metadata
Metadata
Assignees
Labels
Type
Projects
Status