8000 Popups should be hidden on a click away · Issue #62 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Popups should be hidden on a click away #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Slava opened this issue Jan 6, 2015 · 1 comment
Closed

Popups should be hidden on a click away #62

Slava opened this issue Jan 6, 2015 · 1 comment
Labels
UI/UX
Milestone
Release 0.8

Comments

@Slava
Copy link
Slava commented Jan 6, 2015

Click on any button that opens a popup or a submit form such as #AddCardForm. A popup/form opens. Click on any part of the body, that is not a button. The popup/form is expected to be closed.

A simple dumb solution that I came up with is listening on the blur event, but it is bad, because clicking on buttons is also triggering a blur event.
@mquandalle
Copy link

Yes, the popup system needs to be improved. I plan to make a general object that we can use more easily (there is a lot of duplicate code related to click management for instance). And there is also #54.

About the implementation we can simply add an event listener on the body that will close the popup. Then we add a click event on the popup and stop its propagation so that the event does not bubble up to the body tag.

@mquandalle mquandalle modified the milestone: v0.8 Jan 23, 2015
@xet7 xet7 mentioned this issue Feb 8, 2017
Open
< 510D /span> 3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI/UX
Projects
None yet
Milestone
Release 0.8
Development

No branches or pull requests
2 participants
@mquandalle @Slava
0