8000 Update Country Files functions modify QSO data of other users · Issue #769 · wavelog/wavelog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Country Files functions modify QSO data of other users #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000 Open
phl0 opened this issue Aug 17, 2024 · 4 comments
Open

Update Country Files functions modify QSO data of other users #769

phl0 opened this issue Aug 17, 2024 · 4 comments
Assignees
@phl0
Labels
bug Something isn't working discussion This needs a discussion what to do
Milestone
1.8.4

Comments

@phl0
Copy link
Contributor
phl0 commented Aug 17, 2024

From reading the code while coding #767 it seems that not only the distance function but the others ass well also modify QSO data of other users. This is potentially not intended. Needs some investigation and probably a fix.
@phl0 phl0 added bug Something isn't working discussion This needs a discussion what to do labels Aug 17, 2024
@phl0 phl0 added this to the 1.8.3 milestone Aug 17, 2024
@phl0 phl0 self-assigned this Aug 17, 2024
@phl0 phl0 mentioned this issue Aug 17, 2024
Merged
@phl0
Copy link
Contributor Author
phl0 commented Aug 17, 2024

Bug/problem is confirmed. A QSO logged by another user is updated on calling these functions. Needs fixes.

@HB9HIL
Copy link
Contributor
8000 HB9HIL commented Aug 17, 2024

I'm not sure if this is a bug. In fact it's an admin function and the description and usage intends to affect all QSO within Wavelog. tbh: I don't see an issue here but I'm may wrong.

It's not that bad to have some "sanitize" functions which clean the database from missing or wrong data.

@phl0
Copy link
Contributor Author
phl0 commented Aug 17, 2024

Basic question is: Do we want to modify QSO data for any user here?

@int2001
Copy link
Contributor
int2001 commented Aug 18, 2024

Basic question is: Do we want to modify QSO data for any user here?

if admin: Yes
if available for user: only Users QSOs

@phl0 phl0 modified the milestones: 1.8.3, 1.8.4 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phl0 phl0

Labels
bug Something isn't working discussion This needs a discussion what to do
Projects
None yet
Milestone
1.8.4
Development

No branches or pull requests
3 participants
@int2001 @phl0 @HB9HIL
0