8000 Fixed cancel preventing further calls to requestAnimationFrame. by mreuter · Pull Request #52 · wuct/raf-throttle · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed cancel preventing further calls to requestAnimationFrame. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2018
Merged

Fixed cancel preventing further calls to requestAnimationFrame. #52

merged 1 commit into from
Aug 13, 2018

Conversation

mreuter
Copy link
Contributor
@mreuter mreuter commented Aug 10, 2018

Hi,

I just noticed, that the throttled function stopped getting called, after cancelling a requested call, because requestId was not reset to null/undefined.

I added a test-case for this scenario and fixed it.

Kind regards,
Marc

@codecov-io
Copy link

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #52   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          10     11    +1     
  Branches        1      1           
=====================================
+ Hits           10     11    +1
Impacted Files Coverage Δ
rafThrottle.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b49c9...a4ea127. Read the comment docs.

@wuct
Copy link
Owner
wuct commented Aug 13, 2018

Thanks!

@wuct wuct merged commit ec45f3d into wuct:master Aug 13, 2018
@mreuter mreuter deleted the hotfix/cancel branch August 23, 2018 05:34
wuct pushed a commit that referenced this pull request Sep 13, 2020
fix: release the fix in #52
524028d 
This commit is empty because it is for triggering semantic-release.
wuct added a commit that referenced this pull request Sep 13, 2020
@wuct
Merge pull request #120 from wuct/release-fix
7640d3d 
fix: release the fix in #52
@wuct
Copy link
Owner
wuct commented Sep 13, 2020

🎉 This PR is included in version 2.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wuct wuct added the released label Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mreuter @codecov-io @wuct
0