8000 adding a stable way to define ISISROOT · Issue #25 · wtolson/pysis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
adding a stable way to define ISISROOT #25
Open
@michaelaye

Description

@michaelaye

The line:

ISIS_ROOT = os.environ.setdefault('ISISROOT', '/usgs/pkgs/isis3/isis')

in pysis.env is all what controls where to find ISISROOT.
I have found this very fickle in trying to make things work across several conda environments (which is now the default install for ISIS3), so I propose to add functionality to pysis.env.py to get the paths from a config file in the users' home.
Currently, this file on my side simply looks like this:

$ cat .isisroot.toml                                                                        (isis3)
ISISROOT = '/Users/klay6683/miniconda3/envs/isis3'
ISIS3DATA = '/isis3/data'

and I'm using the toml format (https://github.com/toml-lang/toml).
I'm thinking about a few approaches how this fluently could be combined with an existing os.enviroment variable, but let's discuss these details in my PR I gonna start later this week after my current meeting is over (where, of course, I needed pysis to work and it didn't ;) ).

We could also have this config file to be created after the current ISIS3 install, it's simple enough. But much more stable against environment variable manipulations caused by switching conda envs (admittedly, that's the whole idea of conda, obviously).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0