Invalid IDL updates on Dec 30 #205
Comments
|
Update: this has now caused dozens of invalid pull requests to be opened against wpt :(. I'm still OOO, but will be looking tomorrow to disable the automated reffy puller (@foolip) and then close the invalid PRs. |
|
It looks like w3c/webref@358e965 and w3c/webref@99832fa are the commits that updated all IDL files, and this happened on Dec 30 using reffy commit 89d4595. However, that commit is from Dec 11 and appears in reffy-reports commit messages going back to then. So while a respec bump seems like a somewhat plausible cause for this, there's something more going on here... |
|
Here is the GitHub Actions run that pushed w3c/webref@99832fa, and this is a run from before things went wrong. All the versions that I can see in the logs are the same. The version of node installed isn't shown but it seems fairly unlikely that a change in the LTS version of node would have caused this. |
|
Confirmed locally that the same problem occurs with commit 255cd97, renaming this issue to reflect. |
|
Problem seems to be with specs that include https://www.w3.org/Tools/respec/respec-w3c, and the changes from https://github.com/w3c/respec/pull/2663. It'll be necessary to exclude the IDL header to fix this. |
|
Fix up in #208. |
`require('respec')` is nowhere to be found, and the appearance of
pinning respec was misleading in
w3c#205.
It appears that respec will simply be loaded from whatever the spec
points to, such as https://www.w3.org/Tools/respec/respec-w3c.
We're seeing a bunch of automated reffy PRs in https://github.com/web-platform-tests/wpt which seem invalid and seem to have come from 89d4595. They seem to prefix the word 'WebIDL' onto the generated idl.
Example: web-platform-tests/wpt#20941, which changes:
partial interface Navigator {-->WebIDLpartial interface Navigator {[Exposed=Window] interface BatteryManager : EventTarget {-->WebIDL[Exposed=Window] interface BatteryManager : EventTarget {These then fail to parse in the IDL test harness, resulting in harness errors: https://wpt.fyi/results/battery-status/idlharness.https.window.html?diff&filter=ADC&run_id=404190005&run_id=406030001
The text was updated successfully, but these errors were encountered: