8000 Add automatic tpu label to mergify.yml by mgoin · Pull Request #15560 · vllm-project/vllm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add automatic tpu label to mergify.yml #15560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Conversation

mgoin
Copy link
Member
@mgoin mgoin commented Mar 26, 2025

No description provided.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 26, 2025
@mgoin mgoin added tpu Related to Google TPUs ready ONLY add when PR is ready to merge/full CI is needed labels Mar 26, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 26, 2025 22:04
Copy link
Member
@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertgshaw2-redhat robertgshaw2-redhat merged commit ce78f9a into main Mar 27, 2025
26 checks passed
@robertgshaw2-redhat robertgshaw2-redhat deleted the mergify-label-tpu branch March 27, 2025 01:40
russellb added a commit to russellb/vllm that referenced this pull request Mar 27, 2025
This is a follow-up to vllm-project#15560.

The regex `tpu` matches files that include `output` in their name. I
made the list of patterns a little more strict and I think now it
catches everything tpu related without accidentally matching extra
things. Instead of matching `tpu`, it now matches:

- `_tpu` - files or directories that include `_tpu`
- `tpu_` - files or directories that include `tpu_`
- `tpu.py` - filenames that are equal to or end with `tpu.py`
- `/tpu/` - directories named `tpu`

Since the previous rule applied the `tpu` label to some extra PRs, this
includes an additional rule to remove the label from PRs that don't
touch any TPU files. This can be removed later if desired, but letting
it run a bit would automate the cleanup.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0