-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
Add automatic tpu label to mergify.yml #15560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is a follow-up to vllm-project#15560. The regex `tpu` matches files that include `output` in their name. I made the list of patterns a little more strict and I think now it catches everything tpu related without accidentally matching extra things. Instead of matching `tpu`, it now matches: - `_tpu` - files or directories that include `_tpu` - `tpu_` - files or directories that include `tpu_` - `tpu.py` - filenames that are equal to or end with `tpu.py` - `/tpu/` - directories named `tpu` Since the previous rule applied the `tpu` label to some extra PRs, this includes an additional rule to remove the label from PRs that don't touch any TPU files. This can be removed later if desired, but letting it run a bit would automate the cleanup. Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
No description provided.