8000 Remove SKIPPED and HIDE constants · Issue #24 · viktb/security_review · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove SKIPPED and HIDE constants #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
viktb opened this issue Aug 13, 2015 · 2 comments
Open

Remove SKIPPED and HIDE constants #24

viktb opened this issue Aug 13, 2015 · 2 comments
Assignees
@viktb
Labels
8.x-2.x

Comments

@viktb
Copy link
Owner
viktb commented Aug 13, 2015

Remove SKIPPED because:
It's only used in ChecklistController and that usage can be replaced with a workaround. Doesn't make sense to have a constant for this.

Remove HIDE because:
A check could provide information even if it's hidden (e.g. the logs would still show that it succeeded or a dependency was not met; or a Site Audit integration would be able to access these hidden check results), so hiding should be "closer to the front-end". A workaround would be storing a boolean with every check result that indicates whether it's hidden.
@viktb viktb self-assigned this Aug 13, 2015
@viktb viktb added the 8.x-2.x label Aug 16, 2015
@viktb
Copy link
Owner Author
viktb commented Aug 16, 2015

Labeled 8.x-2.x because it's minimally API disruptive and pencils down is tomorrow.
Might be a last 8.x-1.x change in the future, but not as part of GSoC 2015.

@dsnopek
Copy link
dsnopek commented Nov 25, 2015

Made an issue on D.o: https://www.drupal.org/node/2623152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
44CC
Assignees

@viktb viktb

Labels
8.x-2.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsnopek @viktb
0