8000 Should `toJson` be called for null classes? · Issue #16 · vibe-d/vibe-serialization · GitHub

More Web Proxy on the site http://driver.im/

Should `toJson` be called for null classes? #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

VPanteleev-S7 opened this issue May 15, 2025 · 2 comments

Contributor

VPanteleev-S7 commented

/+dub.sdl:
 dependency "vibe-serialization" version="*"
+/
import std.stdio;
import vibe.data.json;

@safe:

class C {
	final Json toJson() const @trusted {
		debug stderr.writeln("C.toJson: ", cast(void*)this);
		return Json(42);
	}
	static typeof(this) fromJson(Json json) @safe {
		return new C;
	}
}


void main() {
	C a = null;
	debug writeln(serializeToJson(a));
}

Looks like, if toJson is defined, it is called even when the class instance is null.

I'm not sure if this is intentional - looks like it might be a potential footgun. For instance, we have to be careful that toJson is not virtual.

The text was updated successfully, but these errors were encountered:

Contributor Author

VPanteleev-S7 commented

ae.utils.json has the same issue 🙈

Member

s-ludwig commented

Since the normal path explicitly checks for null, definitely looks like an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0