8000 Test configuration reloading on Kubernetes · Issue #2224 · vectordotdev/vector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test configuration reloading on Kubernetes #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks
binarylogic opened this issue Apr 4, 2020 · 1 comment
Closed
4 tasks

Test configuration reloading on Kubernetes #2224

binarylogic opened this issue Apr 4, 2020 · 1 comment
Assignees
@MOZGIII
Labels
domain: config Anything related to configuring Vector domain: tests Anything related to Vector's internal tests type: enhancement A value-adding code change that enhances its existing functionality.
Milestone
2020.07.20 - The ...

Comments

@binarylogic
Copy link
Contributor

This might already be done, but it's part of our "Plan Of Attack" in #2222. The purpose is to ensure that config reloading works properly:

  • Reloading works as expected when a new valid config is provided.
  • Vector does not exit when a new invalid config is provided.
  • Vector logs a warning when a new invalid config is provided, but it should not replace the config. It should continue with the old config until a valid config is provided.
  • Vector eventually recovers when a new valid config is provided.

It's likely all of these are satisfied but I want to add explicit tests for these. See #2002.

If any of these tests fail we should open issues for the work.
@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. domain: tests Anything related to Vector's internal tests domain: config Anything related to configuring Vector labels Apr 4, 2020
@binarylogic binarylogic added this to the Initial containers support milestone Apr 4, 2020
@binarylogic binarylogic modified the milestones: Initial Containers Support, 2020.07.19 - The Great Orientation Jul 20, 2020
@MOZGIII
Copy link
Contributor
MOZGIII commented Jul 28, 2020 •
edited
Loading

Since we went with explicit config reloading at #2222, I'm closing this as no longer relevant.

Vector won't reload config on the fly, and instead we'll rely on kubectl rollout restart -n vector ds/vector to update the config.

@MOZGIII MOZGIII closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MOZGIII MOZGIII

Labels
domain: config Anything related to configuring Vector domain: tests Anything related to Vector's internal tests type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
2020.07.20 - The Great Orientation
Development

No branches or pull requests
2 participants
@MOZGIII @binarylogic
0