8000 The SSE2 detection fails on i386 · Issue #761 · vxl/vxl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

The SSE2 detection fails on i386 #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yurivict opened this issue Feb 23, 2020 · 4 comments
Open

The SSE2 detection fails on i386 #761

yurivict opened this issue Feb 23, 2020 · 4 comments
Labels
icebox

Comments

@yurivict
Copy link 
-- Performing Test VXL_HAS_SSE2_HARDWARE_SUPPORT
-- Performing Try-Run Test VXL_HAS_SSE2_HARDWARE_SUPPORT - Test Compilation Failed

http://beefy17.nyi.freebsd.org/data/head-i386-default/p526741_s358237/logs/vxl-2.0.2.629.log (IPv6 URL)

FreeBSD 13 i386
@hjmjohnson
Copy link
Contributor

This is a longstanding problem. Any help in fixing this issue would be greatly appreciated. It is unlikely to get fixed without someone in the community providing a fix.

@hjmjohnson hjmjohnson mentioned this issue Sep 24, 2020
Closed
@yurivict
Copy link
Author
yurivict commented Sep 24, 2020 •
edited
Loading

Something like

if (CMAKE_SYSTEM_PROCESSOR STREQUAL "i386")
  set(CFLAGS ${CFLAGS} -msse2)
  set(CXXFLAGS ${CXXFLAGS} -msse2)
endif()

should do.

@hjmjohnson
Copy link
Contributor

@yurivict I don't think it is a good idea to automatically set values like this. VXL does not 'require' sse2 to work, but if chosen, or specified, it should take advantage of the feature.

I've made an update to make the implementation a bit cleaner, and now require the developer to request the compiler features desired.

Would you mind seeing if the current master branch solves your issues? It should now provide better diagnostic messages if an incompatible configuration is selected.

@yurivict
Copy link
Author

I am not able to build on i386 on demand because of the cost of setting up VMs.
But I will provide feedback in case the next release fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
icebox
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurivict @hjmjohnson
0