8000 Retry warning should show host as well as url/path · Issue #3583 · urllib3/urllib3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Retry warning should show host as well as url/path #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
compwiztobe opened this issue Apr 7, 2025 · 0 comments
Open

Retry warning should show host as well as url/path #3583

compwiztobe opened this issue Apr 7, 2025 · 0 comments

Comments

@compwiztobe
Copy link
compwiztobe commented Apr 7, 2025 •
edited
Loading

When a connection pool retries a request, the warning message prints only the url value, usually a relative path like /simple/virtualenv/ (for connection host https://pypi.org/). Since urllib3 and any calling code are opaquely determining the full url with hostname, it would be useful for debugging for this retry warning to indicate the full path, with something like "%s/%s" % (self.host, url).

urllib3/src/urllib3/connectionpool.py

Lines 868 to 870 in 3e8f2db

log.warning(
"Retrying (%r) after connection broken by '%r': %s", retries, err, url
)

Is there anything in the host determination logic when the request is actually sent that precludes being able to succinctly include this information in the warning message at this scope? (Host should already be fixed as part of the connection object, no?)

Probably other connection classes and request methods would need similar update to any warnings logged there, but HTTPSConnectionPool.urlopen was the method relevant to my use case (pip index resolution).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@compwiztobe
0