8000 Clay fails to serve files when parent commit does not have full history · Issue #6806 · urbit/urbit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Clay fails to serve files when parent commit does not have full history #6806
Open
@zalberico

Description

@zalberico

What is the cause?

When seeing if you can download a desk clay does the following:

  • Looks at the numbered commit of the parent and uses that for its history

This doesn't work in a general case because sometimes the direct parent doesn't have the full history. You have to look at all of the numbered commits (this change is the fix).

What does this mean for remote scry, OTAs, and release?

Sharing some context from what @Fang- , @philipcmonk , and @pkova:

  • this effectively means remote scry doesn't work for OTAs (remote scry relies on this history and fails, but ames gets this history through a different code path that doesn't fail on this)
  • the fallback time to ames is 5min (this explains the slowness we've been seeing with deploys)
  • this makes installing desks very slow (5min wait and then having to do the OTA via ames which is slower than remote scry).

I don't believe this is a new issue, just newly noticed.

@pkova mentioned this will delay the 412 release.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0